RT RT/krbdev.mit.edu: Ticket #2770 com_err generates bad prototypes Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
2770
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
  • krb5-libs
Tags
Version_reported
Version_Fixed
  • 1.4
Target_Version
  • 1.4
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
Referred to by:
 
 Dates  
Created: Fri Nov 5 15:10:18 2004
Starts: Not set
Started: Fri Nov 5 16:23:27 2004
Last Contact: Mon Nov 15 17:17:52 2004
Due: Not set
Updated: Wed Dec 16 18:02:43 2015 by tlyu
 

 People  
Owner
 raeburn
Requestors
 jra@samba.org
Cc
 
AdminCc
 
 

 More about Jeremy Allison  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Fri Nov  5 15:10:19 2004  jra@samba.org - Ticket created    
     
Date: Thu, 4 Nov 2004 17:59:37 -0800
From: Jeremy Allison <jra@samba.org>
To: krb5-bugs@mit.edu
Cc: jra@samba.org
Subject: Bad prototypes.

Hi, is there any chance of the following
patch being accepted for the next release ? I compile Samba with maximum
warnings and the use of

void fn()

instead of the standard C method of :

void fn(void)

always causes nasty warnings on every file :-(.

Jeremy.

-----------------------------------------------------------------------
--- /usr/kerberos-1.3.5/include/krb5.h.orig     2004-11-04 16:45:35.000000000 -0800
+++ /usr/kerberos-1.3.5/include/krb5.h  2004-11-04 16:47:39.000000000 -0800
@@ -2860,7 +2860,7 @@

 #if !defined(_WIN32)
 /* for compatibility with older versions... */
-extern void initialize_krb5_error_table () /*@modifies internalState@*/;
+extern void initialize_krb5_error_table (void) /*@modifies internalState@*/;
 #else
 #define initialize_krb5_error_table()
 #endif
@@ -2911,7 +2911,7 @@

 #if !defined(_WIN32)
 /* for compatibility with older versions... */
-extern void initialize_kdb5_error_table () /*@modifies internalState@*/;
+extern void initialize_kdb5_error_table (void) /*@modifies internalState@*/;
 #else
 #define initialize_kdb5_error_table()
 #endif
@@ -2990,7 +2990,7 @@

 #if !defined(_WIN32)
 /* for compatibility with older versions... */
-extern void initialize_kv5m_error_table () /*@modifies internalState@*/;
+extern void initialize_kv5m_error_table (void) /*@modifies internalState@*/;
 #else
 #define initialize_kv5m_error_table()
 #endif
@@ -3021,7 +3021,7 @@

 #if !defined(_WIN32)
 /* for compatibility with older versions... */
-extern void initialize_k524_error_table () /*@modifies internalState@*/;
+extern void initialize_k524_error_table (void) /*@modifies internalState@*/;
 #else
 #define initialize_k524_error_table()
 #endif
@@ -3056,7 +3056,7 @@

 #if !defined(_WIN32)
 /* for compatibility with older versions... */
-extern void initialize_asn1_error_table () /*@modifies internalState@*/;
+extern void initialize_asn1_error_table (void) /*@modifies internalState@*/;
 #else
 #define initialize_asn1_error_table()
 #endif
-----------------------------------------------------------------------


Download (untitled) 2k
      Fri Nov  5 16:22:50 2004  raeburn - Correspondence added    
     
From: Ken Raeburn <raeburn@MIT.EDU>
Subject: Re: [krbdev.mit.edu #2770] Bad prototypes. 
Date: Fri, 5 Nov 2004 16:22:44 -0500
To: rt@krbdev.mit.edu
RT-Send-Cc: 

On Nov 5, 2004, at 15:10, Jeremy Allison via RT wrote:

> Hi, is there any chance of the following
> patch being accepted for the next release ?

Not quite as such, but the awk/perl scripts that generate the header
files that are joined together to produce krb5.h can be fixed easily
enough. :-)

Ken



Download (untitled) 304b
      Fri Nov  5 16:23:27 2004  raeburn - Status changed from new to resolved    
      Fri Nov  5 16:23:28 2004  raeburn - Tags pullup added    
      Fri Nov  5 16:23:28 2004  raeburn - Given to raeburn    
      Fri Nov  5 16:23:29 2004  raeburn - Correspondence added    
     
From: raeburn@mit.edu
Subject: CVS Commit

* et_h.awk: Declare initialize_*_error_table as taking no arguments.
* et_h.pl: Regenerated.


To generate a diff of this commit:



	cvs diff -r5.149 -r5.150 krb5/src/util/et/ChangeLog
	cvs diff -r5.14 -r5.15 krb5/src/util/et/et_h.awk
	cvs diff -r5.4 -r5.5 krb5/src/util/et/et_h.pl


Download (untitled) 283b
      Fri Nov  5 16:24:12 2004  raeburn - Component krb5-libs added    
      Fri Nov  5 16:24:13 2004  raeburn - Target_Version 1.4 added    
      Fri Nov  5 16:47:57 2004  jra@samba.org - Correspondence added    
     
Date: Fri, 5 Nov 2004 13:47:39 -0800
From: Jeremy Allison <jra@samba.org>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #2770] Bad prototypes.
RT-Send-Cc: 

On Fri, Nov 05, 2004 at 04:22:52PM -0500, Ken Raeburn via RT wrote:
> On Nov 5, 2004, at 15:10, Jeremy Allison via RT wrote:
>
> > Hi, is there any chance of the following
> > patch being accepted for the next release ?
>
> Not quite as such, but the awk/perl scripts that generate the header
> files that are joined together to produce krb5.h can be fixed easily
> enough. :-)

Thanks, yeah - I knew they were auto generated but I thought the
patch might show you what needed fixing :-). They've been getting
better over the years, there used to be many more fn() prototypes
in there.

Cheers,

	Jeremy.


Download (untitled) 609b
      Mon Nov 15 17:17:50 2004  tlyu - Version_Fixed 1.4 added    
      Mon Nov 15 17:17:51 2004  tlyu - Correspondence added    
     
From: tlyu@mit.edu
Subject: CVS Commit

pullup from trunk


To generate a diff of this commit:



	cvs diff -r5.149 -r5.149.4.1 krb5/src/util/et/ChangeLog
	cvs diff -r5.14 -r5.14.4.1 krb5/src/util/et/et_h.awk
	cvs diff -r5.4 -r5.4.4.1 krb5/src/util/et/et_h.pl


Download (untitled) 220b
      Tue Nov 16 13:04:14 2004  tlyu - Subject changed from Bad prototypes. to com_err generates bad prototypes    
      Wed Dec 16 18:02:43 2015  tlyu - Keyword pullup deleted