RT RT/krbdev.mit.edu: Ticket #2781 fix missing locking in keytab; fix stdio handling too Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
2781
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
Version_reported
Version_Fixed
  • 1.4
Target_Version
  • 1.4
Tags
  • pullup
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
  • 1303: (raeburn) thread safety in mit-krb5 libraries [resolved]
Referred to by:
  • 2782: (raeburn) fix missing mutex initialization in keytab file code [resolved]
 
 Dates  
Created: Tue Nov 23 21:39:47 2004
Starts: Not set
Started: Tue Nov 23 21:39:50 2004
Last Contact: Wed Nov 24 18:23:13 2004
Due: Not set
Updated: Wed Dec 8 18:29:12 2004 by tlyu
 

 People  
Owner
 raeburn
Requestors
 raeburn@mit.edu
Cc
 
AdminCc
 
 

 More about Ken Raeburn  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Tue Nov 23 21:39:47 2004  raeburn - Ticket created    
     
From: raeburn@mit.edu
Subject: CVS Commit

The keytab type list lock was implemented, but I missed the per-keytab lock.
Since I was in there, I ripped out the bogus stdio buffer mangling that the
code was doing, and set up a buffer to be used that we can sanitize later.

* kt_file.c (struct _krb5_ktfile_data): Add mutex and buffer.
(KTFILEBUFP, KTLOCK, KTUNLOCK, KTCHECKLOCK): New macros.
(krb5_ktfile_resolve): Initialize mutex.
(krb5_ktfile_close): Zap data buffer before freeing.
(krb5_ktfile_get_entry, krb5_ktfile_start_seq_get, krb5_ktfile_get_next,
krb5_ktfile_end_get, krb5_ktfile_add, krb5_ktfile_remove): Lock and unlock the
mutex.
(krb5_ktfileint_open): Check that the mutex is locked.  Set the stdio buffer to
the new buffer in the ktfile data.
(krb5_ktfileint_write_entry, krb5_ktfileint_find_slot): Check that the mutex is
locked.  Don't call setbuf.  Flush the stdio buffer after writing.


To generate a diff of this commit:



	cvs diff -r5.72 -r5.73 krb5/src/lib/krb5/keytab/ChangeLog
	cvs diff -r5.12 -r5.13 krb5/src/lib/krb5/keytab/kt_file.c


Download (untitled) 1021b
      Tue Nov 23 21:39:50 2004  raeburn - Tags pullup added    
      Tue Nov 23 21:39:50 2004  raeburn - Status changed from new to resolved    
      Tue Nov 23 21:39:51 2004  raeburn - Target_Version 1.4 added    
      Tue Nov 23 21:39:51 2004  raeburn - Requestor raeburn@mit.edu added    
      Wed Nov 24 18:23:11 2004  tlyu - Version_Fixed 1.4 added    
      Wed Nov 24 18:23:12 2004  tlyu - Correspondence added    
     
From: tlyu@mit.edu
Subject: CVS Commit

pullup from trunk


To generate a diff of this commit:



	cvs diff -r5.70.4.2 -r5.70.4.3 krb5/src/lib/krb5/keytab/ChangeLog
	cvs diff -r5.10.4.2 -r5.10.4.3 krb5/src/lib/krb5/keytab/kt_file.c


Download (untitled) 192b
      Wed Dec  8 18:29:12 2004  tlyu - Ticket 2781 RefersTo ticket 1303.