RT RT/krbdev.mit.edu: Ticket #7545 Fix various integer issues Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
7545
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
Tags
Version_reported
Version_Fixed
  • 1.10.4
Target_Version
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
  • 7488: (ghudson) Various nits in krb5-1.10.3 [resolved]
Referred to by:
 
 Dates  
Created: Fri Jan 11 16:04:05 2013
Starts: Not set
Started: Fri Jan 11 16:04:06 2013
Last Contact: Not set
Due: Not set
Updated: Fri Jan 11 19:08:03 2013 by tlyu
 

 People  
Owner
 tlyu
Requestors
 tlyu@mit.edu
Cc
 
AdminCc
 
 

 More about Taylor Yu  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Fri Jan 11 16:04:05 2013  tlyu - Ticket created    
     
From: tlyu@mit.edu
Subject: SVN Commit


Fix various integer issues

In kdc_util.c and spnego_mech.c, error returns from ASN.1 length
functions could be ignored because they were assigned to unsigned
values.  In spnego_mech.c, two buffer size checks could be rewritten
to reduce the likelihood of pointer overflow.  In dump.c and
kdc_preauth.c, calloc() could be used to simplify the code and avoid
multiplication overflow.  In pkinit_clnt.c, the wrong value was
checked for a null result from malloc(), and the code could be
simplified.

Reported by Nickolai Zeldovich <nickolai@csail.mit.edu>.

(cherry picked from commit d3c5450ddf0b20855e86dab41735d56c6860156b)

[tlyu@mit.edu: omitted pkinit and kdb5_util fixes because they're not
conservative]

https://github.com/krb5/krb5/commit/8e31374995eaa4515323e56d1579ee7ad0ebc4ca
Author: Tom Yu <tlyu@mit.edu>
Commit: 8e31374995eaa4515323e56d1579ee7ad0ebc4ca
Branch: krb5-1.10
 src/kdc/kdc_preauth.c               |    3 +--
 src/kdc/kdc_util.c                  |    3 ++-
 src/lib/gssapi/spnego/spnego_mech.c |    6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)


Download (untitled) 1k
      Fri Jan 11 16:04:06 2013  tlyu - Requestor tlyu@mit.edu added    
      Fri Jan 11 16:04:06 2013  tlyu - Status changed from new to resolved    
      Fri Jan 11 16:04:06 2013  tlyu - Version_Fixed 1.10.4 added    
      Fri Jan 11 19:08:03 2013  tlyu - Ticket 7545 RefersTo ticket 7488.