RT RT/krbdev.mit.edu: Ticket #7863 profile library mishandles duplicate subsections Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
7863
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
Tags
Version_reported
Version_Fixed
  • 1.15.3
  • 1.16.1
Target_Version
  • 1.15-next
  • 1.16-next
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
Referred to by:
 
 Dates  
Created: Tue Feb 11 22:07:43 2014
Starts: Not set
Started: Not set
Last Contact: Not set
Due: Not set
Updated: Wed May 2 10:16:07 2018 by ghudson
 

 People  
Owner
 ghudson
Requestors
 ghudson@mit.edu
Cc
 
AdminCc
 
 

 More about Greg Hudson  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Tue Feb 11 22:07:43 2014  ghudson - Ticket created    
     
Subject: profile library mishandles duplicate subsections

In krb5.conf, if you specify the same top-level section (like [realms])
multiple times, you get the same section node each time, because
parse_std_line calls profile_find_node_subsection before
profile_add_node.

But when the parser reads a subsection name, it blindly calls
profile_add_node.  If the subsection already exists, profile_add_node
creates a second subsection with the same name, which will be invisible
to searches.


Download (untitled) 436b
      Tue Apr 17 12:50:16 2018  ghudson - Status changed from open to resolved    
      Tue Apr 17 12:50:16 2018  ghudson - Target_Version 1.16-next added    
      Tue Apr 17 12:50:16 2018  ghudson - Target_Version 1.15-next added    
      Tue Apr 17 12:50:16 2018  ghudson - Tags pullup added    
      Tue Apr 17 12:50:16 2018  ghudson - Given to ghudson    
      Tue Apr 17 12:50:16 2018  ghudson - Correspondence added    
     
From: ghudson@mit.edu
Subject: git commit


Merge duplicate subsections in profile library

Modify profile_add_node() to return the existing node, rather than
making a new one, when adding subsection configuration.

This fixes an issue where the first instance of a subsection will hide
the second instance entirely.  In particular, it was previously
impossible to split realm-specific configuration across multiple
config files.

[ghudson@mit.edu: adjusted style, added test case]

https://github.com/krb5/krb5/commit/efab9fa5a6d23c486467264e20b58bf5a9c60f0c
Author: Robbie Harwood <rharwood@redhat.com>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: efab9fa5a6d23c486467264e20b58bf5a9c60f0c
Branch: master
 src/util/profile/prof_test1  |   22 ++++++++++++++++++++++
 src/util/profile/prof_tree.c |   15 +++++++++++----
 src/util/profile/test.ini    |    6 ++++++
 3 files changed, 39 insertions(+), 4 deletions(-)


Download (untitled) 875b
      Wed May  2 01:25:27 2018  ghudson - Version_Fixed 1.16.1 added    
      Wed May  2 01:25:27 2018  ghudson - Correspondence added    
     
From: ghudson@mit.edu
Subject: git commit


Merge duplicate subsections in profile library

Modify profile_add_node() to return the existing node, rather than
making a new one, when adding subsection configuration.

This fixes an issue where the first instance of a subsection will hide
the second instance entirely.  In particular, it was previously
impossible to split realm-specific configuration across multiple
config files.

[ghudson@mit.edu: adjusted style, added test case]

(cherry picked from commit efab9fa5a6d23c486467264e20b58bf5a9c60f0c)

https://github.com/krb5/krb5/commit/98d0061c8083af960438ad1ac088f60497694a68
Author: Robbie Harwood <rharwood@redhat.com>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 98d0061c8083af960438ad1ac088f60497694a68
Branch: krb5-1.16
 src/util/profile/prof_test1  |   22 ++++++++++++++++++++++
 src/util/profile/prof_tree.c |   15 +++++++++++----
 src/util/profile/test.ini    |    6 ++++++
 3 files changed, 39 insertions(+), 4 deletions(-)


Download (untitled) 948b
      Wed May  2 01:25:56 2018  ghudson - Version_Fixed 1.15.3 added    
      Wed May  2 01:25:56 2018  ghudson - Correspondence added    
     
From: ghudson@mit.edu
Subject: git commit


Merge duplicate subsections in profile library

Modify profile_add_node() to return the existing node, rather than
making a new one, when adding subsection configuration.

This fixes an issue where the first instance of a subsection will hide
the second instance entirely.  In particular, it was previously
impossible to split realm-specific configuration across multiple
config files.

[ghudson@mit.edu: adjusted style, added test case]

(cherry picked from commit efab9fa5a6d23c486467264e20b58bf5a9c60f0c)

https://github.com/krb5/krb5/commit/07596ce5ec6a3491230b0e435b4b124473963aa8
Author: Robbie Harwood <rharwood@redhat.com>
Committer: Greg Hudson <ghudson@mit.edu>
Commit: 07596ce5ec6a3491230b0e435b4b124473963aa8
Branch: krb5-1.15
 src/util/profile/prof_test1  |   22 ++++++++++++++++++++++
 src/util/profile/prof_tree.c |   15 +++++++++++----
 src/util/profile/test.ini    |    6 ++++++
 3 files changed, 39 insertions(+), 4 deletions(-)


Download (untitled) 948b
      Wed May  2 10:16:07 2018  ghudson - Keyword pullup deleted