RT RT/krbdev.mit.edu: Ticket #8645 Fix KDC encrypting key memory leak on some errors Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
8645
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
Tags
Version_reported
Version_Fixed
  • 1.15.3
  • 1.16.1
Target_Version
  • 1.15-next
  • 1.16-next
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
Referred to by:
 
 Dates  
Created: Fri Mar 2 11:46:33 2018
Starts: Not set
Started: Fri Mar 2 11:46:34 2018
Last Contact: Not set
Due: Not set
Updated: Wed May 2 10:16:07 2018 by ghudson
 

 People  
Owner
 ghudson
Requestors
 ghudson@mit.edu
Cc
 
AdminCc
 
 

 More about Greg Hudson  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Fri Mar  2 11:46:33 2018  ghudson - Ticket created    
     
From: ghudson@mit.edu
Subject: git commit


Fix KDC encrypting key memory leak on some errors

Commit 0ba5ccd7bb3ea15e44a87f84ca6feed8890f657d separated the
allocation and destruction of encrypting_key, causing it to leak when
any of the intervening calls jump to the cleanup label.  Currently the
leak manifests on transited or authdata failures.  Move encrypting_key
destruction to the cleanup label so that it can't leak.  Reported by
anedvedicky@gmail.com.

https://github.com/krb5/krb5/commit/1bcf2742d504a22b7354251bbc1e19c3dacd95f3
Author: Greg Hudson <ghudson@mit.edu>
Commit: 1bcf2742d504a22b7354251bbc1e19c3dacd95f3
Branch: master
 src/kdc/do_tgs_req.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


Download (untitled) 683b
      Fri Mar  2 11:46:34 2018  ghudson - Status changed from new to resolved    
      Fri Mar  2 11:46:34 2018  ghudson - Tags pullup added    
      Fri Mar  2 11:46:34 2018  ghudson - Target_Version 1.16-next added    
      Fri Mar  2 11:46:34 2018  ghudson - Target_Version 1.15-next added    
      Fri Mar  2 11:46:34 2018  ghudson - Requestor ghudson@mit.edu added    
      Wed May  2 01:25:36 2018  ghudson - Version_Fixed 1.16.1 added    
      Wed May  2 01:25:36 2018  ghudson - Correspondence added    
     
From: ghudson@mit.edu
Subject: git commit


Fix KDC encrypting key memory leak on some errors

Commit 0ba5ccd7bb3ea15e44a87f84ca6feed8890f657d separated the
allocation and destruction of encrypting_key, causing it to leak when
any of the intervening calls jump to the cleanup label.  Currently the
leak manifests on transited or authdata failures.  Move encrypting_key
destruction to the cleanup label so that it can't leak.  Reported by
anedvedicky@gmail.com.

(cherry picked from commit 1bcf2742d504a22b7354251bbc1e19c3dacd95f3)

https://github.com/krb5/krb5/commit/9377ef950a487757e0ecb15e53537218950747c4
Author: Greg Hudson <ghudson@mit.edu>
Commit: 9377ef950a487757e0ecb15e53537218950747c4
Branch: krb5-1.16
 src/kdc/do_tgs_req.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


Download (untitled) 756b
      Wed May  2 01:26:02 2018  ghudson - Version_Fixed 1.15.3 added    
      Wed May  2 01:26:02 2018  ghudson - Correspondence added    
     
From: ghudson@mit.edu
Subject: git commit


Fix KDC encrypting key memory leak on some errors

Commit 0ba5ccd7bb3ea15e44a87f84ca6feed8890f657d separated the
allocation and destruction of encrypting_key, causing it to leak when
any of the intervening calls jump to the cleanup label.  Currently the
leak manifests on transited or authdata failures.  Move encrypting_key
destruction to the cleanup label so that it can't leak.  Reported by
anedvedicky@gmail.com.

(cherry picked from commit 1bcf2742d504a22b7354251bbc1e19c3dacd95f3)

https://github.com/krb5/krb5/commit/b294627169fba270dbd78cff5e1408a21051b266
Author: Greg Hudson <ghudson@mit.edu>
Commit: b294627169fba270dbd78cff5e1408a21051b266
Branch: krb5-1.15
 src/kdc/do_tgs_req.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


Download (untitled) 756b
      Wed May  2 10:16:07 2018  ghudson - Keyword pullup deleted