RT RT/krbdev.mit.edu: Ticket #3236 krb5.h included in internal files prior to k5-int.h Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
3236
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
  • krb5-libs
Version_reported
  • 1.4.3
Version_Fixed
  • 1.4.4
Target_Version
  • 1.4.4
Tags
 

 Relationships  
Depends on:
Depended on by:
  • 2883: (jaltman) 64-bit time_t issues [resolved]
  • 3250: (tlyu) don't break make depend in lib/crypto on k5-int.h ordering [resolved]
Parents:
Children:

Refers to:
Referred to by:
  • 3252: (raeburn) Tru64 compilation fails after k5-int.h/krb5.h changes [resolved]
 
 Dates  
Created: Thu Nov 10 20:54:37 2005
Starts: Not set
Started: Not set
Last Contact: Mon Nov 28 19:02:21 2005
Due: Not set
Updated: Mon Nov 28 19:02:21 2005 by tlyu
 

 People  
Owner
 jaltman
Requestors
 jaltman@mit.edu
Cc
 
AdminCc
 
 

 More about Jeffrey Altman  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Thu Nov 10 20:54:38 2005  jaltman - Ticket created    
     
Subject: krb5.h included in internal files prior to k5-int.h

The following files include "krb5.h" when they should include
"k5-int.h".  Their inclusion of "krb5.h" results in krb5.h being loaded
before a later inclusion of "k5-int.h".

src/lib/krb5/asn.1/krb5decode.c
src/lib/krb5/asn.1/krb5encode.c
src/lib/krb5/ccache/ccapi/winccld.c
src/lib/krb5/ccache/ccapi/stdcc.c
src/lib/krb5/rcache/rc_io.c
src/lib/krb5/krb5_libinit.c
src/lib/gssapi/krb5/gssapiP_krb5.h



Download (untitled) 403b
      Thu Nov 10 20:55:26 2005  jaltman - Component krb5-libs added    
      Thu Nov 10 20:55:27 2005  jaltman - Version_reported 1.4.3 added    
      Mon Nov 14 18:12:45 2005  tlyu - Target_Version 1.4.4 added    
      Mon Nov 14 19:31:49 2005  jaltman - Status changed from open to resolved    
      Mon Nov 14 19:31:50 2005  jaltman - Correspondence added    
     
From: jaltman@mit.edu
Subject: CVS Commit

This commit ensures that all files in the library include
k5-int.h before krb5.h is included either directly or
indirectly.  This is to allow Kerberos to use pre-processor
symbols to choose configurations of C run time library headers
without affecting third party applications.


Commit By: jaltman



Revision: 17489
Changed Files:
U   trunk/src/lib/gssapi/krb5/ChangeLog
U   trunk/src/lib/gssapi/krb5/gssapiP_krb5.h
U   trunk/src/lib/krb5/ChangeLog
U   trunk/src/lib/krb5/asn.1/ChangeLog
U   trunk/src/lib/krb5/asn.1/krb5_decode.c
U   trunk/src/lib/krb5/asn.1/krb5_encode.c
U   trunk/src/lib/krb5/ccache/ccapi/ChangeLog
U   trunk/src/lib/krb5/ccache/ccapi/stdcc.c
U   trunk/src/lib/krb5/ccache/ccapi/winccld.c
U   trunk/src/lib/krb5/krb5_libinit.c
U   trunk/src/lib/krb5/rcache/ChangeLog
U   trunk/src/lib/krb5/rcache/rc_io.c


Download (untitled) 830b
      Wed Nov 16 19:50:28 2005  raeburn - Status changed from resolved to open    
      Wed Nov 16 19:50:29 2005  raeburn - Correspondence added    
     
Lots of non--krb5-library stuff, especially the kadmin libraries and
programs, also includes k5-int.h.  The UNIX builds stopped working once
k5-int.h started to error out if krb5.h had already been included.


Download (untitled) 207b
      Thu Nov 17 20:22:20 2005  raeburn - Status changed from open to resolved    
      Thu Nov 17 20:22:20 2005  raeburn - Correspondence added    
     
From: raeburn@mit.edu
Subject: CVS Commit

Fix additional cases where krb5.h is included before k5-int.h.  In most cases,
it suffices to remove the inclusion of k5-int.h, sometimes including errno.h or
another header.  In a couple cases, include order has been changed, or k5-int.h
has been included instead of krb5.h.

Commit By: raeburn



Revision: 17494
Changed Files:
U   trunk/src/kadmin/cli/ChangeLog
U   trunk/src/kadmin/cli/kadmin.c
U   trunk/src/kadmin/cli/keytab.c
U   trunk/src/kadmin/testing/util/ChangeLog
U   trunk/src/kadmin/testing/util/tcl_kadm5.c
U   trunk/src/kadmin/testing/util/tcl_ovsec_kadm.c
U   trunk/src/krb524/ChangeLog
U   trunk/src/krb524/krb524d.c
U   trunk/src/lib/kadm5/ChangeLog
U   trunk/src/lib/kadm5/admin.h
U   trunk/src/lib/kadm5/clnt/ChangeLog
U   trunk/src/lib/kadm5/clnt/client_init.c
U   trunk/src/lib/kadm5/clnt/client_principal.c
U   trunk/src/lib/kadm5/clnt/clnt_policy.c
U   trunk/src/lib/kadm5/clnt/err_handle.h
U   trunk/src/lib/kadm5/kadm_rpc_xdr.c
U   trunk/src/lib/kadm5/server_internal.h
U   trunk/src/lib/kadm5/srv/ChangeLog
U   trunk/src/lib/kadm5/srv/server_init.c
U   trunk/src/lib/kadm5/srv/svr_policy.c
U   trunk/src/lib/kadm5/srv/svr_principal.c
U   trunk/src/lib/kadm5/unit-test/ChangeLog
U   trunk/src/lib/kadm5/unit-test/setkey-test.c
U   trunk/src/modules/kdb/db2/ChangeLog
U   trunk/src/modules/kdb/db2/policy_db.h
U   trunk/src/tests/asn.1/ChangeLog
U   trunk/src/tests/asn.1/utility.c
U   trunk/src/tests/asn.1/utility.h


Download (untitled) 1.4k
      Thu Nov 17 20:28:12 2005  raeburn - Status changed from resolved to open    
      Thu Nov 17 20:28:12 2005  raeburn - Comments added    
     
oops, still missed some, reopening


Download (untitled) 34b
      Thu Nov 17 20:29:51 2005  raeburn - Status changed from open to resolved    
      Thu Nov 17 20:29:51 2005  raeburn - Correspondence added    
     
From: raeburn@mit.edu
Subject: CVS Commit

* fakeka.c: Include errno.h.

Commit By: raeburn



Revision: 17495
Changed Files:
U   trunk/src/kdc/ChangeLog
U   trunk/src/kdc/fakeka.c


Download (untitled) 138b
      Thu Nov 17 20:55:04 2005  raeburn - Correspondence added    
     
From: raeburn@mit.edu
Subject: CVS Commit

* t_hmac.c, t_pkcs5.c: Don't include krb5.h.

Commit By: raeburn



Revision: 17499
Changed Files:
U   trunk/src/lib/crypto/ChangeLog
U   trunk/src/lib/crypto/t_hmac.c
U   trunk/src/lib/crypto/t_pkcs5.c


Download (untitled) 203b
      Mon Nov 28 19:02:17 2005  tlyu - Version_Fixed 1.4.4 added    
      Mon Nov 28 19:02:18 2005  tlyu - Correspondence added    
     
From: tlyu@mit.edu
Subject: CVS Commit

Pull up r17489, r17494, r17495, r17499 from trunk, along with some
back-porting due to divergence caused by DAL integration.

Commit By: tlyu



Revision: 17503
Changed Files:
U   branches/krb5-1-4/src/kadmin/cli/ChangeLog
U   branches/krb5-1-4/src/kadmin/cli/kadmin.c
U   branches/krb5-1-4/src/kadmin/cli/keytab.c
U   branches/krb5-1-4/src/kadmin/testing/util/ChangeLog
U   branches/krb5-1-4/src/kadmin/testing/util/tcl_kadm5.c
U   branches/krb5-1-4/src/kadmin/testing/util/tcl_ovsec_kadm.c
U   branches/krb5-1-4/src/kdc/ChangeLog
U   branches/krb5-1-4/src/kdc/fakeka.c
U   branches/krb5-1-4/src/krb524/ChangeLog
U   branches/krb5-1-4/src/krb524/krb524d.c
U   branches/krb5-1-4/src/lib/crypto/ChangeLog
U   branches/krb5-1-4/src/lib/crypto/t_hmac.c
U   branches/krb5-1-4/src/lib/crypto/t_pkcs5.c
U   branches/krb5-1-4/src/lib/gssapi/krb5/ChangeLog
U   branches/krb5-1-4/src/lib/gssapi/krb5/gssapiP_krb5.h
U   branches/krb5-1-4/src/lib/kadm5/ChangeLog
U   branches/krb5-1-4/src/lib/kadm5/adb.h
U   branches/krb5-1-4/src/lib/kadm5/admin.h
U   branches/krb5-1-4/src/lib/kadm5/clnt/ChangeLog
U   branches/krb5-1-4/src/lib/kadm5/clnt/client_init.c
U   branches/krb5-1-4/src/lib/kadm5/clnt/client_principal.c
U   branches/krb5-1-4/src/lib/kadm5/clnt/clnt_policy.c
U   branches/krb5-1-4/src/lib/kadm5/kadm_rpc_xdr.c
U   branches/krb5-1-4/src/lib/kadm5/server_internal.h
U   branches/krb5-1-4/src/lib/kadm5/srv/ChangeLog
U   branches/krb5-1-4/src/lib/kadm5/srv/adb_openclose.c
U   branches/krb5-1-4/src/lib/kadm5/srv/server_init.c
U   branches/krb5-1-4/src/lib/kadm5/srv/svr_principal.c
U   branches/krb5-1-4/src/lib/kadm5/unit-test/ChangeLog
U   branches/krb5-1-4/src/lib/kadm5/unit-test/setkey-test.c
U   branches/krb5-1-4/src/lib/krb5/ChangeLog
U   branches/krb5-1-4/src/lib/krb5/asn.1/ChangeLog
U   branches/krb5-1-4/src/lib/krb5/asn.1/krb5_decode.c
U   branches/krb5-1-4/src/lib/krb5/asn.1/krb5_encode.c
U   branches/krb5-1-4/src/lib/krb5/ccache/ccapi/ChangeLog
U   branches/krb5-1-4/src/lib/krb5/ccache/ccapi/stdcc.c
U   branches/krb5-1-4/src/lib/krb5/ccache/ccapi/winccld.c
U   branches/krb5-1-4/src/lib/krb5/krb5_libinit.c
U   branches/krb5-1-4/src/lib/krb5/rcache/ChangeLog
U   branches/krb5-1-4/src/lib/krb5/rcache/rc_io.c
U   branches/krb5-1-4/src/tests/asn.1/ChangeLog
U   branches/krb5-1-4/src/tests/asn.1/utility.c
U   branches/krb5-1-4/src/tests/asn.1/utility.h


Download (untitled) 2.3k