Subject: NIM update inconsistency when deleting credentials

Configuration:

Windows XP SP2 or Vista.

NIM from either MIT KfW Beta 2 or from secure-
endpoints.com/binaries/mit-kfw-3-2-0/kfw-3-2-0.msi.


Test scenario:

Obtain default identity credentials.

Display the NIM GUI, standard view.

Destroy the default identity credentials, either by clicking the
Destroy toolbar button or by right clicking the tray icon and select
Destroy | default identity.

The silhouette disappears from the tray icon but the time remaining is
still shown on the second line of the default identity display.

Clicking the Refresh View toolbar button or selecting View | Refresh
from the menu does not update the display.

Cycling to the advanced view and back to the standard view via F7 F7
updates the default identity display with a blank second line.

Patch to fix Refresh button behavior:

Index: mainwnd.c
===================================================================
--- mainwnd.c   (revision 19739)
+++ mainwnd.c   (working copy)
@@ -261,6 +261,7 @@
         case KHUI_ACTION_VIEW_REFRESH:
             khm_cred_refresh();
             InvalidateRect(khm_hwnd_main_cred, NULL, FALSE);
+            khui_action_trigger(KHUI_ACTION_LAYOUT_RELOAD, NULL);
             return 0;

         case KHUI_ACTION_PASSWD_ID:

Date: Thu, 02 Aug 2007 09:44:56 -0400
From: Jeffrey Altman <jaltman@secure-endpoints.com>
To: kfw-bugs@mit.edu
Subject: Re: [krbdev.mit.edu #5604] NIM update inconsistency when deleting credentials
RT-Send-Cc: 

 

Kevin Koch via RT wrote:
> Patch to fix Refresh button behavior:
>
> Index: mainwnd.c
> ===================================================================
> --- mainwnd.c   (revision 19739)
> +++ mainwnd.c   (working copy)
> @@ -261,6 +261,7 @@
>          case KHUI_ACTION_VIEW_REFRESH:
>              khm_cred_refresh();
>              InvalidateRect(khm_hwnd_main_cred, NULL, FALSE);
> +            khui_action_trigger(KHUI_ACTION_LAYOUT_RELOAD, NULL);
>              return 0;
>
>          case KHUI_ACTION_PASSWD_ID:
>
As I pointed out previously, this is the wrong change.  What you are
doing here is simulating the effect that switching back and forth
between the basic and advanced views would have.  You have not actually
identified the cause of the problem.

The question to be answered is "why is the basic view credential list
not being updated?"

More than likely there is a race condition somewhere.  If you find that,
you will probably fix several of your tickets.  Covering over the
problem with a superficial change like this will just make it harder to
find the true issue.

Date: Thu, 02 Aug 2007 09:49:23 -0400
From: Jeffrey Altman <jaltman@secure-endpoints.com>
To: kfw-bugs@mit.edu
Subject: Re: [krbdev.mit.edu #5604] NIM update inconsistency when deleting credentials
RT-Send-Cc: 

 

Kevin Koch via RT wrote:
> Patch to fix Refresh button behavior:
>
> Index: mainwnd.c
> ===================================================================
> --- mainwnd.c   (revision 19739)
> +++ mainwnd.c   (working copy)
> @@ -261,6 +261,7 @@
>          case KHUI_ACTION_VIEW_REFRESH:
>              khm_cred_refresh();
>              InvalidateRect(khm_hwnd_main_cred, NULL, FALSE);
> +            khui_action_trigger(KHUI_ACTION_LAYOUT_RELOAD, NULL);
>              return 0;
>
>          case KHUI_ACTION_PASSWD_ID:
>
As I pointed out yesterday, this is the wrong patch to apply.  What this
patch will do is reload the layout and the credentials as if the user
had toggled from basic to advanced and back.  What you have done is
altered the timing which means you have covered up a race condition but
have not actually solved the real cause of the problem that you are
experiencing in this ticket and perhaps several others.

Find the race, fix the race.

From: kpkoch@mit.edu
Subject: SVN Commit

Simulate changing views when the REFRESH action is run and when credentials are
updated.

This makes the symptoms go away but does not solve whatever the underlying problem
is.
Commit By: kpkoch



Revision: 19770
Changed Files:
U   trunk/src/windows/identity/ui/mainwnd.c
U   trunk/src/windows/identity/ui/timer.c

Date: Thu, 09 Aug 2007 13:36:14 -0400
From: Jeffrey Altman <jaltman@secure-endpoints.com>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #5604] SVN Commit
RT-Send-Cc: 

 

Kevin Koch via RT wrote:
> Simulate changing views when the REFRESH action is run and when credentials are
updated.
>
> This makes the symptoms go away but does not solve whatever the underlying problem
is.
> Commit By: kpkoch
>
>
>
> Revision: 19770
> Changed Files:
> U   trunk/src/windows/identity/ui/mainwnd.c
> U   trunk/src/windows/identity/ui/timer.c

While it may be necessary for MIT to ship with this change for their
next release, the change should be pulled immediately following the
release tag in order to ensure that the real problem is addressed in
a future release.  The existence of this change is going to make it
harder for the real problem to be fixed.

Please open a new ticket for the real problem and have it
reference ticket 5604.

From: tlyu@mit.edu
Subject: SVN Commit

pull up r19770 from trunk

 r19770@cathode-dark-space:  kpkoch | 2007-08-09 10:52:15 -0400
 Ticket: 5604
 Tags: pullup
 Target_Version: 1.6.3

 Simulate changing views when the REFRESH action is run and when credentials are
updated.

 This makes the symptoms go away but does not solve whatever the underlying problem
is.


Commit By: tlyu



Revision: 19799
Changed Files:
_U  branches/krb5-1-6/
U   branches/krb5-1-6/src/windows/identity/ui/mainwnd.c
U   branches/krb5-1-6/src/windows/identity/ui/timer.c

From: kpkoch@mit.edu
Subject: SVN Commit

Simulate changing views when the REFRESH action is run and when credentials are
updated.
This makes the symptoms go away but does not solve whatever the underlying problem
is.

I missed this change yesterday.

This should be added to kfw-3_2_1-beta2.
Commit By: kpkoch



Revision: 19813
Changed Files:
U   trunk/src/windows/identity/ui/credwnd.c

From: tlyu@mit.edu
Subject: SVN Commit

pull up r19813 from trunk

 r19813@cathode-dark-space:  kpkoch | 2007-08-10 10:37:04 -0400
 Ticket: 5604
 Tags: pullup
 Target_Version: 1.6.3
 Tags: Pullup

 Simulate changing views when the REFRESH action is run and when credentials are
updated.
 This makes the symptoms go away but does not solve whatever the underlying problem
is.

 I missed this change yesterday.

 This should be added to kfw-3_2_1-beta2.


Commit By: tlyu



Revision: 19814
Changed Files:
_U  branches/krb5-1-6/
U   branches/krb5-1-6/src/windows/identity/ui/credwnd.c