RT RT/krbdev.mit.edu: Ticket #5607 NIM GUI: Default identity display should not have a background color Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
5607
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
  • windows
Version_reported
Version_Fixed
  • 1.6.3
Target_Version
  • 1.6.3
Tags
  • pullup
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
Referred to by:
  • 5651: (jaltman) The Removal of Colors (ticket 5607) [resolved]
 
 Dates  
Created: Mon Jul 30 10:40:39 2007
Starts: Not set
Started: Thu Aug 9 09:23:05 2007
Last Contact: Thu Aug 9 18:13:39 2007
Due: Not set
Updated: Thu Jun 19 19:57:37 2008 by guest
 

 People  
Owner
 kpkoch
Requestors
 kpkoch@mit.edu
Cc
 
AdminCc
 jaltman@mit.edu
 

 More about Kevin Koch  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Mon Jul 30 10:40:39 2007  kpkoch - Ticket created    
     
Subject: NIM GUI: Default identity display should not have a background color

NIM from either MIT KfW Beta 2 or from secure-
endpoints.com/binaries/mit-kfw-3-2-0/kfw-3-2-0.msi.


The default identity in the NIM GUI is highlighted in green. This is
confusing because in the NIM tray icon, green means you have
credentials.

The default identity is already indicated with the text ‘(Default).’

The default-background color makes it hard to apply other background
color indications such as the red expired color.

The coloring for default should NOT be green, red etc.


Download (untitled) 494b
      Wed Aug  1 18:20:19 2007  jaltman - AdminCc jaltman@mit.edu added    
      Thu Aug  2 10:19:31 2007  jaltman - Correspondence added    
     
The color schemes can certainly use some improvement.

Removing the background color from the default identity is ok.


Download (untitled) 122b
      Thu Aug  2 14:44:47 2007  kpkoch - Correspondence added    
     
Patch:

Index: credwnd.c
===================================================================
--- credwnd.c   (revision 19739)
+++ credwnd.c   (working copy)
@@ -685,7 +689,7 @@
         COLORREF bg_hdr_warn = RGB(235,235,134);
         COLORREF bg_hdr_crit = RGB(235,184,134);
         COLORREF bg_hdr_exp = RGB(235,134,134);
-        COLORREF bg_hdr_def = RGB(184,235,134);
+        COLORREF bg_hdr_def = GetSysColor(COLOR_WINDOW);

         tbl->cr_normal =       GetSysColor(COLOR_WINDOWTEXT);
         tbl->cr_s =            GetSysColor(COLOR_WINDOWTEXT);


Download (untitled) 559b
      Thu Aug  9 09:23:04 2007  kpkoch - Given to kpkoch    
      Thu Aug  9 09:23:05 2007  kpkoch - Status changed from new to resolved    
      Thu Aug  9 09:23:05 2007  kpkoch - Correspondence added    
     
From: kpkoch@mit.edu
Subject: SVN Commit

The background color is changed to COLOR_WINDOW.
Commit By: kpkoch



Revision: 19768
Changed Files:
U   trunk/src/windows/identity/ui/credwnd.c


Download (untitled) 145b
      Thu Aug  9 15:15:20 2007  kpkoch - Queue changed from kfw to krb5    
      Thu Aug  9 15:15:41 2007  kpkoch - Component windows added    
      Thu Aug  9 15:15:41 2007  kpkoch - Target_Version 1.6.3 added    
      Thu Aug  9 15:15:42 2007  kpkoch - Tags pullup added    
      Thu Aug  9 18:13:35 2007  tlyu - Version_Fixed 1.6.3 added    
      Thu Aug  9 18:13:35 2007  tlyu - Correspondence added    
     
From: tlyu@mit.edu
Subject: SVN Commit

pull up r19768 from trunk

 r19768@cathode-dark-space:  kpkoch | 2007-08-09 09:22:59 -0400
 Ticket: 5607
 Tags: pullup
 Target_Version: 1.6.3

 The background color is changed to COLOR_WINDOW.


Commit By: tlyu



Revision: 19795
Changed Files:
_U  branches/krb5-1-6/
U   branches/krb5-1-6/src/windows/identity/ui/credwnd.c


Download (untitled) 325b