From: jaltman@mit.edu
Subject: SVN Commit

Export krb5_get_profile.  Remove comment saying it should be
added and just do it.


Commit By: jaltman



Revision: 19818
Changed Files:
U   trunk/src/lib/krb5_32.def

From: Ken Raeburn <raeburn@MIT.EDU>
Subject: Re: [krbdev.mit.edu #5645] SVN Commit 
Date: Mon, 13 Aug 2007 22:30:27 -0400
To: rt@krbdev.mit.edu
RT-Send-Cc: 

On Aug 11, 2007, at 11:15, Jeffrey Altman via RT wrote:
> Export krb5_get_profile.  Remove comment saying it should be
> added and just do it.

Your change also added several other symbols to the export list,
including some not conforming to the krb5* and profile* naming
scheme, and not listed in krb5.h.  If they are in fact needed, we
should define new names for them, and consider making them public.

Several of the symbols newly exported also don't have calling
conventions specified, which stops the Linux build (and perhaps we
should add that check to the Windows build process as well).

If you don't need them in the next 1.6.x and KfW releases, please
revert that part of the change.  If you do, I'd like to hear why.

From: jaltman@mit.edu
Subject: SVN Commit

remove inadvertent commit of symbols temporarily exported in
a sandbox to permit building of pkinit code on Windows.


Commit By: jaltman



Revision: 19819
Changed Files:
U   trunk/src/lib/krb5_32.def

Date: Mon, 13 Aug 2007 22:59:38 -0400
From: Jeffrey Altman <jaltman@mit.edu>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #5645] SVN Commit
RT-Send-Cc: 

Ken Raeburn via RT wrote:

> Your change also added several other symbols to the export list,

unintentional and they have been reverted.

> including some not conforming to the krb5* and profile* naming
> scheme, and not listed in krb5.h.  If they are in fact needed, we
> should define new names for them, and consider making them public.

I will make a proposal as to what symbols are required for export
as part of the pkinit implementation on Windows.  However, they
should be accessed via the accessor export function as they are private.

From: Ken Raeburn <raeburn@MIT.EDU>
Subject: Re: [krbdev.mit.edu #5645] SVN Commit
Date: Tue, 14 Aug 2007 05:03:42 -0400
To: rt@krbdev.mit.edu
RT-Send-Cc: 

> unintentional and they have been reverted.

Thanks.

> I will make a proposal as to what symbols are required for export
> as part of the pkinit implementation on Windows.  However, they
> should be accessed via the accessor export function as they are
> private.

Agreed.

Ken

From: tlyu@mit.edu
Subject: SVN Commit

pull up r19818 from trunk

 r19818@cathode-dark-space:  jaltman | 2007-08-11 11:15:44 -0400
 ticket: new
 subject: export krb5_get_profile
 tags: pullup

 Export krb5_get_profile.  Remove comment saying it should be
 added and just do it.




Commit By: tlyu



Revision: 19903
Changed Files:
_U  branches/krb5-1-6/
U   branches/krb5-1-6/src/lib/krb5_32.def

From: tlyu@mit.edu
Subject: SVN Commit

pull up r19819 from trunk

 r19819@cathode-dark-space:  jaltman | 2007-08-13 22:54:15 -0400
 ticket: 5645

 remove inadvertent commit of symbols temporarily exported in
 a sandbox to permit building of pkinit code on Windows.




Commit By: tlyu



Revision: 19904
Changed Files:
_U  branches/krb5-1-6/
U   branches/krb5-1-6/src/lib/krb5_32.def