RT RT/krbdev.mit.edu: Ticket #7143 krb5_set_trace_filename not exported Signed in as guest.
[Logout]

[Home] [Search] [Configuration]

[Display] [History] [Basics] [Dates] [People] [Links] [Jumbo]

 
 

 The Basics  
Id
7143
Status
resolved
Worked
0 min
Priority
0/0
Queue
krb5
 

 Keyword Selections  
Component
Version_reported
Version_Fixed
  • 1.10.2
Target_Version
  • 1.10.2
Tags
  • pullup
 

 Relationships  
Depends on:
Depended on by:
Parents:
Children:

Refers to:
Referred to by:
  • 7169: (tlyu) Export krb5_set_trace_callback/filename [resolved]
 
 Dates  
Created: Sat May 19 13:33:46 2012
Starts: Not set
Started: Mon May 21 01:39:37 2012
Last Contact: Mon May 21 15:49:55 2012
Due: Not set
Updated: Mon May 21 15:49:55 2012 by tlyu
 

 People  
Owner
 ghudson
Requestors
 Russ Allbery <rra@stanford.edu>
Cc
 
AdminCc
 
 

 More about Russ Allbery  
Comments about this user:
No comment entered about this user
This user's 25 highest priority tickets:
 

History   Display mode: [Brief headers] [Full headers]
      Sat May 19 13:33:46 2012  rra - Ticket created    
     
Subject: krb5_set_trace_filename not exported

I finally implemented an option to pam-krb5 to enable trace logging for
debugging (pam-krb5 almost always uses a secure context, so the
environment variable doesn't work), only to find that while
krb5_set_trace_filename is prototyped in krb5.h, it isn't exported by
the library.  I assume this is an oversight?


Download (untitled) 310b
      Sat May 19 15:01:52 2012  ghudson - Correspondence added    
     
Yes, that's an oversight.  (The krb5_set_trace_callback API also needs to
be exported, and both also need to be added to krb5_32.def.)


Download (untitled) 135b
      Mon May 21 01:39:36 2012  ghudson - Given to ghudson    
      Mon May 21 01:39:37 2012  ghudson - Target_Version 1.10.2 added    
      Mon May 21 01:39:37 2012  ghudson - Status changed from new to review    
      Mon May 21 01:39:37 2012  ghudson - Tags pullup added    
      Mon May 21 01:39:37 2012  ghudson - Correspondence added    
     
From: ghudson@mit.edu
Subject: SVN Commit


Export krb5_set_trace_callback/filename

krb5_set_trace_callback and krb5_set_trace_filename were added to
krb5.h in krb5 1.9, but were mistakenly left out of the library export
lists.  Add them now.  Reported by Russ Allbery.

https://github.com/krb5/krb5/commit/61e6ab231b75f7ac3ff8967f002436e48ce05620
Author: Greg Hudson <ghudson@mit.edu>
Commit: 61e6ab231b75f7ac3ff8967f002436e48ce05620
Branch: master
 src/lib/krb5/libkrb5.exports |    2 ++
 src/lib/krb5_32.def          |    5 ++++-
 2 files changed, 6 insertions(+), 1 deletions(-)


Download (untitled) 541b
      Mon May 21 01:42:36 2012  ghudson - Comments added    
     
This should also be pulled up to 1.9.  The patch to krb5_32.def won't
apply to either branch, but applying the functional part by hand should be
easy.


Download (untitled) 152b
      Mon May 21 15:49:55 2012  tlyu - Status changed from review to resolved    
      Mon May 21 15:49:55 2012  tlyu - Version_Fixed 1.10.2 added    
      Mon May 21 15:49:55 2012  tlyu - Correspondence added    
     
From: tlyu@mit.edu
Subject: SVN Commit


Export krb5_set_trace_callback/filename

krb5_set_trace_callback and krb5_set_trace_filename were added to
krb5.h in krb5 1.9, but were mistakenly left out of the library export
lists.  Add them now.  Reported by Russ Allbery.

(backported from commit 61e6ab231b75f7ac3ff8967f002436e48ce05620)

https://github.com/krb5/krb5/commit/d0e740185b3f5732055dfa9a76a98c193d36b412
Author: Greg Hudson <ghudson@mit.edu>
Committer: Tom Yu <tlyu@mit.edu>
Commit: d0e740185b3f5732055dfa9a76a98c193d36b412
Branch: krb5-1.10
 src/lib/krb5/libkrb5.exports |    2 ++
 src/lib/krb5_32.def          |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)


Download (untitled) 642b