From jhawk@MIT.EDU  Sun Oct  6 19:26:28 1996
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id TAA05807 for <bugs@RT-11.MIT.EDU>; Sun, 6 Oct 1996 19:26:27 -0400
Received: from LOLA-GRANOLA.MIT.EDU by MIT.EDU with SMTP
	id AA26312; Sun, 6 Oct 96 19:26:27 EDT
Received: (from jhawk@localhost) by lola-granola.MIT.EDU (8.6.12/8.6.12) id TAA24937; Sun, 6 Oct 1996 19:26:26 -0400
Message-Id: <199610062326.TAA24937@lola-granola.MIT.EDU>
Date: Sun, 6 Oct 1996 19:26:26 -0400
From: John Hawkinson <jhawk@bbnplanet.com>
To: krb5-bugs@MIT.EDU
Subject: telnet "env" subcommand miscounts arguments

>Number:         75
>Category:       telnet
>Synopsis:       telnet "env" subcommand miscounts arguments
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hartmans
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Sun Oct e 19:27:00 EDT 1996
>Last-Modified:  Mon Oct e 02:27:04 EDT 1996
>Originator:     
>Organization:
		 BBN Planet
>Release:        beta-7
>Environment:
System: SunOS all-purpo 4.1.4 4 sun4m
Architecture: sun4

>Description:

The telnet "env" subcommand miscounts the number of arguments that it
gets. This causes it to misprint the word "only" in some cases.

>How-To-Repeat:

telnet> env varval
Need only 1 argument to 'environ varval' command.  'environ ?' for help.

>Fix:

There's a sign error in the code.

*** appl/telnet/telnet/commands.c	1996/10/06 23:10:12	1.1
--- appl/telnet/telnet/commands.c	1996/10/06 23:21:52	1.2
***************
*** 1661,1667 ****
      if (c->narg + 2 != argc) {
  	fprintf(stderr,
  	    "Need %s%d argument%s to 'environ %s' command.  'environ ?' for help.\n",
! 		c->narg < argc + 2 ? "only " : "",
  		c->narg, c->narg == 1 ? "" : "s", c->name);
  	return 0;
      }
--- 1661,1667 ----
      if (c->narg + 2 != argc) {
  	fprintf(stderr,
  	    "Need %s%d argument%s to 'environ %s' command.  'environ ?' for help.\n",
! 		c->narg < argc - 2 ? "only " : "",
  		c->narg, c->narg == 1 ? "" : "s", c->name);
  	return 0;
      }
>Audit-Trail:

State-Changed-From-To: open-closed
State-Changed-By: hartmans
State-Changed-When: Mon Oct 14 02:26:40 1996
State-Changed-Why:
Fix by applying patch

>Unformatted: