From evanc@cello.synapse.net Sun Dec 7 11:02:51 1997 Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id LAA20656 for ; Sun, 7 Dec 1997 11:02:50 -0500 Received: from cello.synapse.net by MIT.EDU with SMTP id AA01257; Sun, 7 Dec 97 11:02:54 EST Received: (qmail 9102 invoked by uid 0); 7 Dec 1997 16:02:48 -0000 Message-Id: <19971207160247.9101.qmail@cello.synapse.net> Date: 7 Dec 1997 16:02:47 -0000 From: evanc@synapse.net To: krb5-bugs@MIT.EDU Cc: evanc@synapse.net Subject: ncurses doesn't have ttytype[], with patch X-Send-Pr-Version: 3.99 >Number: 513 >Category: krb5-appl >Synopsis: ncurses doesn't have ttytype[], with patch >Confidential: no >Severity: serious >Priority: medium >Responsible: krb5-unassigned >State: open >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Sun Dec 07 11:03:01 EST 1997 >Last-Modified: >Originator: Evan Champion >Organization: >Release: krb5-1.0.4 >Environment: System: FreeBSD cello.synapse.net 3.0-CURRENT FreeBSD 3.0-CURRENT #0: Sat Dec 6 16:07:02 EST 1997 evanc@cello.synapse.net:/usr/src/sys/compile/CELLO i386 >Description: I have setupterm(), but not extern char ttytype[] -- it is not a part of ncurses. This prevents telnet from compiling if it finds setupterm(). I don't think that there is much to be gained from using the ttytype[] as opposed to termbuf[], so I moved the termbuf[] declaration outside the #ifdef, and removed the ttytype[] #define/extern. >How-To-Repeat: >Fix: *** 1/krb5-1.0.4/src/appl/telnet/telnet/telnet.c Thu Dec 4 22:42:20 1997 --- krb5-1.0.4/src/appl/telnet/telnet/telnet.c Sat Dec 6 20:31:52 1997 *************** *** 742,750 **** return (1); } - #ifndef HAVE_SETUPTERM char termbuf[1024]; /*ARGSUSED*/ int setupterm(tname, fd, errp) --- 742,750 ---- return (1); } char termbuf[1024]; + #ifndef HAVE_SETUPTERM /*ARGSUSED*/ int setupterm(tname, fd, errp) *************** *** 761,769 **** *errp = 0; return(-1); } - #else - #define termbuf ttytype - extern char ttytype[]; #endif int resettermname = 1; --- 761,766 ---- >Audit-Trail: >Unformatted: