pull up r22348 from trunk ------------------------------------------------------------------------ r22348 | tlyu | 2009-05-13 22:41:37 +0200 (Wed, 13 May 2009) | 13 lines ticket: 6486 tags: pullup target_version: 1.7 In util/support/utf8_conv.c, the SWAP16 macro is invoked with an argument that has side effects. On platforms where SWAP16 can evaluate its argument twice (including platforms where utf8_conv.c creates a fallback definition for the SWAP16 macro), this can cause a read overrun by a factor of two. Rearrange the data flow to avoid calling SWAP16 with an argument that has side effects. https://github.com/krb5/krb5/commit/2fd6b6c82430f8544d01542ba8573f7bf3218bb5 Commit By: tlyu Revision: 22371 Changed Files: U branches/krb5-1-7/src/util/support/utf8_conv.c