From elr@panix.com Tue Jan 8 20:27:02 2002 Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.7.7.76]) by rt-11.mit.edu (8.9.3/8.9.3) with ESMTP id UAA01273 for ; Tue, 8 Jan 2002 20:27:02 -0500 (EST) Received: from mail3.panix.com (mail3.panix.com [166.84.0.167]) by fort-point-station.mit.edu (8.9.2/8.9.2) with ESMTP id UAA20389 for ; Tue, 8 Jan 2002 20:27:01 -0500 (EST) Received: from panix1.panix.com (panix1.panix.com [166.84.1.1]) by mail3.panix.com (Postfix) with ESMTP id 921D598190 for ; Tue, 8 Jan 2002 20:27:01 -0500 (EST) Received: (from elr@localhost) by panix1.panix.com (8.11.3nb1/8.8.8/PanixN1.0) id g091R1q19730 for krb5-bugs@mit.edu; Tue, 8 Jan 2002 20:27:01 -0500 (EST) Message-Id: <200201090127.g091R1q19730@panix1.panix.com> Date: Tue, 8 Jan 2002 20:27:01 -0500 (EST) From: "Ed Ravin [staff]" To: krb5-bugs@mit.edu Subject: krb5-1.2.2 fixes for NetBSD >Number: 1037 >Category: krb5-build >Synopsis: krb5-1.2.2 fixes for NetBSD >Confidential: yes >Severity: serious >Priority: medium >Responsible: tlyu >State: open >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Tue Jan 8 20:28:01 EST 2002 >Last-Modified: Thu Apr 4 16:43:56 EST 2002 >Originator: >Organization: >Release: >Environment: >Description: >How-To-Repeat: >Fix: >Audit-Trail: From: Sam Hartman To: "Ed Ravin [staff]" Cc: krb5-bugs@MIT.EDU Subject: Re: pending/1037: krb5-1.2.2 fixes for NetBSD Date: 10 Jan 2002 05:03:48 -0500 >>>>> "Ed" == Ed Ravin [staff] writes: Ed> NetBSD uses a slightly different PTY scheme than the usual - Ed> the letter "v" (i.e. ttyv[0-9a-f]) is reserved for an archaic Ed> virtual console driver, so the usual way of manually Ed> determining the next available PTY doesn't work when you get Ed> to the letter "v". A patch for the problem is below. We've Ed> used this patch on NetBSD 1.4 and 1.5 systems, up to 1.5.2. Hi. For future reference, we're fairly unlikely to accept patches that special case a particular OS. We'd much rather see feature tests. For example in this case I don't think special casing NetBSD is appropriate because other BSDs have used pcvt in the past. Certainly if you do submit patches with OS-specific bits in the future, please try to explain why no generic feature test can reasonably be written. That said, even if you don't have time to patch the problem in a clean manner, please at least report the problem. Thanks much, --Sam Responsible-Changed-From-To: gnats-admin->tlyu Responsible-Changed-By: hartmans Responsible-Changed-When: Thu Apr 4 16:43:52 2002 Responsible-Changed-Why: >Unformatted: NetBSD uses a slightly different PTY scheme than the usual - the letter "v" (i.e. ttyv[0-9a-f]) is reserved for an archaic virtual console driver, so the usual way of manually determining the next available PTY doesn't work when you get to the letter "v". A patch for the problem is below. We've used this patch on NetBSD 1.4 and 1.5 systems, up to 1.5.2. I presume there's some generic way to ask the OS for the next available PTY, but since I don't know how to do it I'd better shut up now. :-) Thanks, -- Ed Ed Ravin Systems Administrator PANIX - Public Access Networks Corporation --- http://www.panix.com (212) 741 4400 "Please state the nature of the network emergency..." ----------------------------------- diff -u -r1.1 util/pty/getpty.c --- util/pty/getpty.c 2001/08/02 03:03:57 1.1 +++ util/pty/getpty.c 2001/08/02 03:13:39 @@ -112,7 +112,11 @@ strncpy(slave, slavebuf, slavelength); return 0; } else { - for (cp = "pqrstuvwxyzPQRST";*cp; cp++) { +#ifdef __NetBSD__ + for (cp = "pqrstuwxyzPQRST";*cp; cp++) { +#else + for (cp = "pqrstuvwxyzPQRST";*cp; cp++) { +#endif sprintf(slavebuf,"/dev/ptyXX"); slavebuf[sizeof("/dev/pty") - 1] = *cp; slavebuf[sizeof("/dev/ptyp") - 1] = '0';