From epeisach@MIT.EDU  Sat Nov  2 22:19:10 1996
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id WAA26651 for <bugs@RT-11.MIT.EDU>; Sat, 2 Nov 1996 22:19:10 -0500
Received: from KANGAROO.MIT.EDU by MIT.EDU with SMTP
	id AA13170; Sat, 2 Nov 96 22:19:09 EST
Received: by kangaroo.mit.edu; (5.65/1.1.8.2/08Mar96-0212PM)
	id AA10155; Sat, 2 Nov 1996 22:19:08 -0500
Message-Id: <9611030319.AA10155@kangaroo.mit.edu>
Date: Sat, 2 Nov 1996 22:19:08 -0500
From: epeisach@MIT.EDU
Reply-To: epeisach@MIT.EDU
To: krb5-bugs@MIT.EDU
Subject: Cannot compile appl/bsd --without-krb4
X-Send-Pr-Version: 3.99

>Number:         148
>Category:       krb5-appl
>Synopsis:       Cannot compile appl/bsd --without-krb4
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    hartmans
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Sat Nov e 22:20:01 EST 1996
>Last-Modified:  Sat Nov 09 11:02:02 EST 1996
>Originator:     Ezra Peisach
>Organization:
mit
>Release:        1.0-development
>Environment:
	
System: OSF1 kangaroo.mit.edu V3.2 214 alpha
Machine: alpha
>Description:
	login.c has a problem if KRb4 support is not compiled in.

>How-To-Repeat:
	configure and compile
>Fix:
Index: login.c
===================================================================
RCS file: /mit/krb5/.cvsroot/src/appl/bsd/login.c,v
retrieving revision 5.56
diff -c -r5.56 login.c
*** login.c	1996/11/02 05:43:35	5.56
--- login.c	1996/11/03 03:14:48
***************
*** 1671,1677 ****
  		  syslog(LOG_ERR,
  			 "%s while creating V5 krbtgt principal",
  			 error_message(retval));
! 		  goto skip_ccache_rewrite;
  	     }
  
  	       mcreds.ticket_flags =0;
--- 1671,1678 ----
  		  syslog(LOG_ERR,
  			 "%s while creating V5 krbtgt principal",
  			 error_message(retval));
! 		  rewrite_ccache=0;
! 		  goto skip_ccache_rewrite_cont;
  	     }
  
  	       mcreds.ticket_flags =0;
***************
*** 1682,1688 ****
  		  syslog(LOG_ERR,
  			 "%s while retrieiving V5 initial ticket for copy",
  			 error_message(retval));
! 		  goto skip_ccache_rewrite;
  	     }
  	     krb5_free_principal(kcontext, mcreds.server);
  	}
--- 1683,1690 ----
  		  syslog(LOG_ERR,
  			 "%s while retrieiving V5 initial ticket for copy",
  			 error_message(retval));
! 		  rewrite_ccache=0;
! 		  goto skip_ccache_rewrite_cont;
  	     }
  	     krb5_free_principal(kcontext, mcreds.server);
  	}
***************
*** 1697,1707 ****
  			 "%s while retrieving V4 initial ticket for copy",
  			 error_message(retval));
  	     skip_ccache_rewrite: rewrite_ccache = 0;
- 	     
  	     }
  	}
  #endif /* KRB4_GET_TICKETS */
  #if defined(KRB5_GET_TICKETS) || defined(KRB4_GET_TICKETS)
  	if (got_v5_tickets || got_v4_tickets)
  	  destroy_tickets();
  #endif
--- 1699,1709 ----
  			 "%s while retrieving V4 initial ticket for copy",
  			 error_message(retval));
  	     skip_ccache_rewrite: rewrite_ccache = 0;
  	     }
  	}
  #endif /* KRB4_GET_TICKETS */
  #if defined(KRB5_GET_TICKETS) || defined(KRB4_GET_TICKETS)
+       skip_ccache_rewrite_cont:
  	if (got_v5_tickets || got_v4_tickets)
  	  destroy_tickets();
  #endif

>Audit-Trail:

Responsible-Changed-From-To: krb5-unassigned->hartmans
Responsible-Changed-By: hartmans
Responsible-Changed-When: Sat Nov  9 08:22:20 1996
Responsible-Changed-Why:
Oops; I *thought*  I fixed this.

State-Changed-From-To: open-closed 
State-Changed-By: hartmans 
State-Changed-When: Sat Nov 9 11:01:18 EST 1996 
State-Changed-Why:  
Fixed by removing the label from the krb4 case 
and moving it up into the krb5 case. 
Changed login.c 

>Unformatted: