From epeisach@MIT.EDU  Fri Feb  7 12:59:55 1997
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id MAA09720 for <bugs@RT-11.MIT.EDU>; Fri, 7 Feb 1997 12:59:54 -0500
Received: from KANGAROO.MIT.EDU by MIT.EDU with SMTP
	id AA22885; Fri, 7 Feb 97 12:59:53 EST
Received: by kangaroo.mit.edu; (5.65/1.1.8.2/08Mar96-0212PM)
	id AA18382; Fri, 7 Feb 1997 12:59:51 -0500
Message-Id: <9702071759.AA18382@kangaroo.mit.edu>
Date: Fri, 7 Feb 1997 12:59:51 -0500
From: epeisach@MIT.EDU
Reply-To: epeisach@MIT.EDU
To: krb5-bugs@MIT.EDU
Subject: Win16 credential forwarding
X-Send-Pr-Version: 3.99

>Number:         367
>Category:       krb5-libs
>Synopsis:       Win16 credential forwarding
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    basch
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Fri Feb 07 13:00:00 EST 1997
>Last-Modified:  Fri Feb 07 15:33:30 EST 1997
>Originator:     Ezra Peisach
>Organization:
	MIT
>Release:        1.0
>Environment:
System: OSF1 kangaroo.mit.edu V3.2 214 alpha
Machine: alpha
Apparently under Win16
>Description:
An old bug that we missed going to gnats...


From: Doug Engert <DEEngert@anl.gov>
To: krb5-bugs@mit.edu
Subject: k5b6 Windows bug
Date: Tue, 9 Jul 96 08:23:11 CDT


I got ticket forwarding from a windows 3.1 system working this
morning, after I applied the attached change.

krb5_mk_ncred_basic is expecting a krb5_int32, but the krb5_mk_ncred
has ncred defined as an int.  With Windows 16 bit mode, since there is
not prototype for the internal function, a 16 bit value is pased on
the stack, while a 32 bit is expected.

Suggested fixes include: define ncred as krb5_int32, add a prototype,
or type cast the parameter.

*** ,mk_cred.c  Wed Mar 20 22:20:12 1996
--- mk_cred.c   Tue Jul  9 07:53:05 1996
***************
*** 299,305 ****
      }

      /* Setup creds structure */
!     if ((retval = krb5_mk_ncred_basic(context, ppcreds, ncred, keyblock,
                      &replaydata, plocal_fulladdr,
                      premote_fulladdr, pcred))) {
    goto error;
--- 299,305 ----
      }

      /* Setup creds structure */
!     if ((retval = krb5_mk_ncred_basic(context, ppcreds, (krb5_int32)ncred, key
block,
                      &replaydata, plocal_fulladdr,
                      premote_fulladdr, pcred))) {
    goto error;


 

>How-To-Repeat:
>Fix:
2/7/96 basch
Fixed - declared ncreds as krb5_int32.
>Audit-Trail:
>Unformatted: