From dsr@lnscu5.lns.cornell.edu Fri Feb 22 15:01:44 2002 Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.7.21.83]) by rt-11.mit.edu (8.9.3/8.9.3) with ESMTP id PAA20869 for ; Fri, 22 Feb 2002 15:01:44 -0500 (EST) Received: from lnscu5.lns.cornell.edu (lnscu5.lns.cornell.edu [128.84.44.111]) by pacific-carrier-annex.mit.edu (8.9.2/8.9.2) with ESMTP id PAA22719 for ; Fri, 22 Feb 2002 15:01:43 -0500 (EST) Received: from lnscu6.lns.cornell.edu (lnscu6.lns.cornell.edu [128.84.45.151]) by lnscu5.lns.cornell.edu (8.12.1/8.12.1) with ESMTP id g1MK1ho2012975 for ; Fri, 22 Feb 2002 15:01:43 -0500 (EST) Received: by lnscu6.lns.cornell.edu (8.8.8/1.1.22.3/15Feb00-0854AM) id PAA0000019878; Fri, 22 Feb 2002 15:01:43 -0500 (EST) Message-Id: <200202222001.PAA0000019878@lnscu6.lns.cornell.edu> Date: Fri, 22 Feb 2002 15:01:43 -0500 (EST) From: Dan Riley Reply-To: dsr@mail.lns.cornell.edu To: krb5-bugs@mit.edu Subject: printf argument mismatches in rpc unit tests X-Send-Pr-Version: 3.99 >Number: 1066 >Category: krb5-libs >Synopsis: printf argument mismatches in rpc unit tests >Confidential: no >Severity: non-critical >Priority: low >Responsible: krb5-unassigned >State: closed >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Fri Feb 22 15:02:01 EST 2002 >Last-Modified: Sun Apr 7 19:09:38 EDT 2002 >Originator: Dan Riley >Organization: LNS, Cornell U. >Release: krb5-1.2.3 >Environment: System: OSF1 lnscu6.lns.cornell.edu V4.0 1229 alpha Machine: alpha >Description: Two of the fprintf's in the rpc unit tests have argument mismatches. >How-To-Repeat: Compile with a very picky compiler and read the warnings (the Tru64 5.1 cc, for instance). >Fix: diff -ur krb5-1.2.3/src/lib/rpc/unit-test/client.c krb5/lib/rpc/unit-test/client.c --- krb5-1.2.3/src/lib/rpc/unit-test/client.c Wed Jan 9 17:27:59 2002 +++ krb5/lib/rpc/unit-test/client.c Thu Dec 6 13:01:48 2001 @@ -217,7 +223,7 @@ if (strncmp(*echo_resp, "Echo: ", 6) && strcmp(echo_arg, (*echo_resp) + 6) != 0) fprintf(stderr, "RPC_TEST_ECHO call %d response wrong: " - "arg = %s, resp = %s\n", echo_arg, *echo_resp); + "arg = %s, resp = %s\n", i, echo_arg, *echo_resp); gssrpc_xdr_free(xdr_wrapstring, echo_resp); } @@ -323,7 +329,7 @@ if (strncmp(*echo_resp, "Echo: ", 6) && strcmp(echo_arg, (*echo_resp) + 6) != 0) fprintf(stderr, - "RPC_TEST_LENGTHS call %d response wrong\n"); + "RPC_TEST_LENGTHS call %d response wrong\n", i); gssrpc_xdr_free(xdr_wrapstring, echo_resp); } >Audit-Trail: State-Changed-From-To: open-closed State-Changed-By: hartmans State-Changed-When: Sun Apr 7 19:08:57 2002 State-Changed-Why: This bug does appear to be fixed in our development code; I will probably not be pulled into to a 1.2.x release of Kerberos, but should be in 1.3. >Unformatted: