From jl@arioch.austin.ibm.com Tue Jun 22 14:25:36 1999 Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id OAA16584 for ; Tue, 22 Jun 1999 14:25:35 -0400 Received: from ausmail.austin.ibm.com by MIT.EDU with SMTP id AA26351; Tue, 22 Jun 99 14:24:58 EDT Received: from netmail2.austin.ibm.com (netmail2.austin.ibm.com [9.53.250.97]) by ausmail.austin.ibm.com (8.9.1/8.8.5) with ESMTP id NAA41186 for ; Tue, 22 Jun 1999 13:26:16 -0500 Received: from arioch.austin.ibm.com (arioch.austin.ibm.com [9.53.149.124]) by netmail2.austin.ibm.com (8.8.5/8.8.5) with ESMTP id NAA27154 for ; Tue, 22 Jun 1999 13:25:31 -0500 Received: (from jl@localhost) by arioch.austin.ibm.com (AIX4.3/UCB 8.8.8/8.7-client1.01) id NAA30338; Tue, 22 Jun 1999 13:25:30 -0500 Message-Id: <199906221825.NAA30338@arioch.austin.ibm.com> Date: Tue, 22 Jun 1999 13:25:30 -0500 From: lackeyj@austin.ibm.com Reply-To: lackeyj@austin.ibm.com To: krb5-bugs@MIT.EDU Subject: Build problem in AIX 4.3.2 X-Send-Pr-Version: 3.99 >Number: 727 >Category: krb5-appl >Synopsis: Build problem in AIX 4.3.2 >Confidential: no >Severity: non-critical >Priority: medium >Responsible: raeburn >State: analyzed >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Tue Jun 22 14:26:00 EDT 1999 >Last-Modified: Fri Jul 09 16:07:00 EDT 1999 >Originator: Joshua Lackey >Organization: lackeyj@austin.ibm.com >Release: krb5-1.0.6 >Environment: System: AIX arioch 3 4 000775304C00 >Description: In src/appl/bsd/login.c the function rmufile() is called. This is an internal (non-public) routine that has been removed in (at least) AIX 4.3.2. >How-To-Repeat: Build krb5-1.0.6 on AIX 4.3.2. >Fix: The correct calls follow: *** krb5-1.0.6/src/appl/bsd/login.c.orig Fri Jun 18 10:16:40 1999 --- krb5-1.0.6/src/appl/bsd/login.c Tue Jun 22 11:36:04 1999 *************** *** 2535,2542 **** putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); } else { putgroupattr(grp, S_USERS, (void *)empty, SEC_LIST); putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); - rmufile(grp, 0, GROUP_TABLE); } } while (*grp) grp++; --- 2535,2542 ---- putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); } else { putgroupattr(grp, S_USERS, (void *)empty, SEC_LIST); + putgroupattr(grp, (char *)0, (void *)0, SEC_DELETE); putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); } } while (*grp) grp++; >Audit-Trail: State-Changed-From-To: open-feedback State-Changed-By: raeburn State-Changed-When: Thu Jul 1 19:38:24 1999 State-Changed-Why: Is putgroupattr(..., SEC_DELETE) the right way to do this for older versions of AIX as well, or should we make it conditional on the availability of rmufile? Responsible-Changed-From-To: gnats-admin->raeburn Responsible-Changed-By: raeburn Responsible-Changed-When: Thu Jul 1 19:44:14 1999 Responsible-Changed-Why: I'll take it... State-Changed-From-To: feedback-analyzed State-Changed-By: raeburn State-Changed-When: Fri Jul 9 15:38:49 1999 State-Changed-Why: From: Joshua Lackey Date: Thu, 8 Jul 1999 12:22:09 -0500 Reply-To: lackeyj@austin.ibm.com Message-Id: <19990708122208.A48290@arioch.austin.ibm.com> Ken, The SEC_DELETE SEC_COMMIT method should be used for versions 4.3.0 and above. Versions prior to 4.3.0 will still have to use rmufile. Josh. From: Ken Raeburn To: lackeyj@austin.ibm.com Cc: krb5-bugs@MIT.EDU Subject: Re: pending/727: Build problem in AIX 4.3.2 Date: 09 Jul 1999 16:06:45 -0400 Thanks. Do you know if 4.3.0 got rid of rmufile, or should I use some other test? Here's the patch I'm considering at the moment, if you'd like to try it out; you'll need to run util/reconf from the top of the tree. (I don't have access to an AIX system currently.) Ken Index: configure.in =================================================================== RCS file: /cvs/krbdev/krb5/src/appl/bsd/configure.in,v retrieving revision 5.85 diff -p -u -r5.85 configure.in --- configure.in 1999/02/17 22:26:32 5.85 +++ configure.in 1999/07/09 19:41:32 @@ -63,7 +63,7 @@ AC_SUBST(V4RCPO) dnl AC_VFORK AC_TYPE_MODE_T -AC_CHECK_FUNCS(isatty inet_aton gettosbyname killpg initgroups setpriority setreuid setresuid waitpid setsid ptsname setlogin tcgetpgrp tcsetpgrp setpgid strsave utimes) +AC_CHECK_FUNCS(isatty inet_aton gettosbyname killpg initgroups setpriority setreuid setresuid waitpid setsid ptsname setlogin tcgetpgrp tcsetpgrp setpgid strsave utimes rmufile) AC_CHECK_HEADERS(unistd.h stdlib.h string.h sys/filio.h sys/sockio.h sys/label.h sys/tty.h ttyent.h lastlog.h sys/select.h sys/ptyvar.h utmp.h sys/time.h krb4-proto.h sys/ioctl_compat.h paths.h arpa/nameser.h) AC_HEADER_STDARG AC_REPLACE_FUNCS(getdtablesize) Index: login.c =================================================================== RCS file: /cvs/krbdev/krb5/src/appl/bsd/login.c,v retrieving revision 5.74 diff -p -u -r5.74 login.c --- login.c 1999/01/21 02:44:00 5.74 +++ login.c 1999/07/09 19:41:32 @@ -2428,8 +2428,13 @@ update_ref_count(int adj) putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); } else { putgroupattr(grp, S_USERS, (void *)empty, SEC_LIST); +#ifdef HAVE_RMUFILE /* pre-4.3.0 AIX */ putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); rmufile(grp, 0, GROUP_TABLE); +#else + putgroupattr(grp, (char *)0, (void *)0, SEC_DELETE); + putgroupattr(grp, (char *)0, (void *)0, SEC_COMMIT); +#endif } } while (*grp) grp++; >Unformatted: