Received: from saint-elmos-fire.mit.edu (tlyu@SAINT-ELMOS-FIRE.MIT.EDU [18.18.0.248]) by krbdev.mit.edu (8.9.3) with ESMTP id QAA06371; Fri, 13 Sep 2002 16:00:15 -0400 (EDT) Received: (from tlyu@localhost) by saint-elmos-fire.mit.edu (8.9.3) id QAA00602; Fri, 13 Sep 2002 16:00:06 -0400 (EDT) To: Wolfgang.Friebel@cern.ch Cc: rt-comment@krbdev.mit.edu Subject: Re: [krbdev.mit.edu #1146] string2key gets wrong salt with Heimdal KDC and converted AFS accounts References: From: Tom Yu Date: Fri, 13 Sep 2002 16:00:06 -0400 In-Reply-To: (Wolfgang FRIEBEL's message of "Fri, 13 Sep 2002 11:19:46 +0200 (CEST)") Message-Id: Lines: 10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii RT-Send-Cc: X-RT-Original-Encoding: us-ascii Content-Length: 433 >>>>> "WF" == Wolfgang FRIEBEL writes: WF> there was a typo in the 3 lines to be included. The test on c must of WF> course not be >= 0 but > 0 only. It would even be better to get the salt WF> correct in the first place, i.e. at the place where salt->data is set. I corrected the patch when I checked it in for the 1.2.6 release; it checks that the pointer returned from strchr() is not NULL. ---Tom