Received: from blade.devel.redhat.com (nat-pool-rdu.redhat.com [66.187.233.200]) by krbdev.mit.edu (8.9.3) with ESMTP id PAA01420; Fri, 11 Oct 2002 15:17:41 -0400 (EDT)
Received: from blade.devel.redhat.com (localhost.localdomain [127.0.0.1]) by blade.devel.redhat.com (8.12.5/8.12.5) with ESMTP id g9BJHQTG030667 for <rt@krbdev.mit.edu>; Fri, 11 Oct 2002 15:17:26 -0400
Received: (from nalin@localhost) by blade.devel.redhat.com (8.12.5/8.12.5/Submit) id g9BJHQWq030665 for rt@krbdev.mit.edu; Fri, 11 Oct 2002 15:17:26 -0400
Date: Fri, 11 Oct 2002 15:17:26 -0400
From: Nalin Dahyabhai <nalin@redhat.com>
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #1216]
Message-Id: <20021011191726.GF24739@redhat.com>
References: <rt-1216-3174.14.2755314938672@krbdev.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <rt-1216-3174.14.2755314938672@krbdev.mit.edu>
User-Agent: Mutt/1.4i
X-Random-Fortune: Do not try to solve all life's problems at once -- learn to dread each day as it comes.  -- Donald Kaul
Organization: Red Hat, Inc.
X-Department: OS Development
X-Disclaimer: I am not a spokesmodel.  Views expressed are my own.
X-Key-Id: 2537B551
X-Key-Fingerprint: 60BC AD87 AF51 3A00 8C99  0388 379B CE57 7868 8BF5
RT-Send-Cc: 
X-RT-Original-Encoding: us-ascii
Content-Length: 486

On Thu, Oct 10, 2002 at 07:27:21PM -0400, Tom Yu via RT wrote:
> Thanks for the patch...
[snip]
> nalin> @@ -463,6 +463,8 @@
> nalin>          CHECK(p,2);
> nalin>  	rdlen = NTOHSP(p,2);
>  
> nalin> +	CHECK(p,rdlen);
> nalin> +
> 
> Could you please explain why this check for rdlen was added?  It seems
> redundant.

Oh, you're right.  I was trying to guard against missing data for other
RR types, but there's an else block around line 520 that already does
the job.

Thanks,

Nalin