Received: from biscayne-one-station.mit.edu (BISCAYNE-ONE-STATION.MIT.EDU [18.7.7.80]) by krbdev.mit.edu (8.12.9) with ESMTP id lA9KiEHW020897; Fri, 9 Nov 2007 15:44:14 -0500 (EST)
Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by biscayne-one-station.mit.edu (8.13.6/8.9.2) with ESMTP id lA9Ki8FG006755 for <rt@krbdev.MIT.EDU>; Fri, 9 Nov 2007 15:44:08 -0500 (EST)
Received: from cathode-dark-space.mit.edu (CATHODE-DARK-SPACE.MIT.EDU [18.18.1.96]) (authenticated bits=56) (User authenticated as tlyu@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id lA9Ki7C2023178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for <rt@krbdev.MIT.EDU>; Fri, 9 Nov 2007 15:44:08 -0500 (EST)
Received: (from tlyu@localhost) by cathode-dark-space.mit.edu (8.12.9.20060308) id lA9Ki7t9025327; Fri, 9 Nov 2007 15:44:07 -0500 (EST)
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #5840] Prevent kadm5_decrypt_key() from coercing the keytype if the requested ktype == -1
References: <rt-5840-25651.18.3778159093524@krbdev.mit.edu>
From: Tom Yu <tlyu@MIT.EDU>
Date: Fri, 09 Nov 2007 15:44:07 -0500
In-Reply-To: <rt-5840-25651.18.3778159093524@krbdev.mit.edu> (Jeffrey Altman via's message of "Fri, 9 Nov 2007 15:14:52 -0500 (EST)")
Message-ID: <ldvy7d7w3mw.fsf@cathode-dark-space.mit.edu>
Lines: 7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Scanned-BY: MIMEDefang 2.42
X-Spam-Flag: NO
X-Spam-Score: 0.00
RT-Send-Cc: 
X-RT-Original-Encoding: us-ascii
Content-Length: 232

>>>>> "jaltman" == Jeffrey Altman via RT <rt-comment@krbdev.mit.edu> writes:

jaltman> +    if (ktype == -1)
jaltman> +        keyblock->enctype = ktype;

Isn't this backwards if you want -1 to mean the enctype doesn't get
coerced?