Received: from biscayne-one-station.mit.edu (BISCAYNE-ONE-STATION.MIT.EDU [18.7.7.80]) by krbdev.mit.edu (8.12.9) with ESMTP id m6NKaxo4020101; Wed, 23 Jul 2008 16:36:59 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by biscayne-one-station.mit.edu (8.13.6/8.9.2) with ESMTP id m6NKarpu014820; Wed, 23 Jul 2008 16:36:53 -0400 (EDT) Received: from NOME-KING.MIT.EDU (NOME-KING.MIT.EDU [18.18.1.160]) (authenticated bits=0) (User authenticated as raeburn@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id m6NKaqYR016870 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 23 Jul 2008 16:36:53 -0400 (EDT) Message-ID: From: Ken Raeburn To: rt@krbdev.mit.edu In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Subject: Re: [krbdev.mit.edu #6041] WIN32 SOCKET != int in gss and rpc libs MIME-Version: 1.0 (Apple Message framework v928.1) Date: Wed, 23 Jul 2008 16:36:51 -0400 References: X-Mailer: Apple Mail (2.928.1) X-Scanned-BY: MIMEDefang 2.42 X-Spam-Flag: NO X-Spam-Score: 0.00 RT-Send-Cc: X-RT-Original-Encoding: us-ascii Content-Length: 722 On Jul 23, 2008, at 13:25, Jeffrey Altman via RT wrote: > sure although I don't understand why ignoring that return value should > be treated specially. It's not that there's anything special about close/closesocket, I just don't want to make removing such casts a part of this otherwise fairly specific change, in the absence of a specific coding style guideline regarding ignored return values. >> Why do you need to define INVALID_SOCKET in svc_udp.c? > > INVALID_SOCKET is a special value on Windows which is architecture > dependent. Is INVALID_SOCKET defined somewhere else for Unix? Yes, port-sockets.h already has a definition for the UNIX case. The revised patch looks good, please check it in... Ken