Received: from biscayne-one-station.mit.edu (BISCAYNE-ONE-STATION.MIT.EDU [18.7.7.80]) by krbdev.mit.edu (8.12.9) with ESMTP id m7KJtBo4009706; Wed, 20 Aug 2008 15:55:11 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by biscayne-one-station.mit.edu (8.13.6/8.9.2) with ESMTP id m7KJt4Rd028043; Wed, 20 Aug 2008 15:55:04 -0400 (EDT) Received: from NOME-KING.MIT.EDU (NOME-KING.MIT.EDU [18.18.1.160]) (authenticated bits=0) (User authenticated as raeburn@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id m7KJt3Ga020330 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 20 Aug 2008 15:55:04 -0400 (EDT) Message-ID: From: Ken Raeburn To: rt@krbdev.mit.edu In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Subject: Re: [krbdev.mit.edu #6090] k5_mutex_destroy calls pthread_mutex_destroy with mutex locked MIME-Version: 1.0 (Apple Message framework v928.1) Date: Wed, 20 Aug 2008 15:55:03 -0400 References: X-Mailer: Apple Mail (2.928.1) X-Scanned-BY: MIMEDefang 2.42 X-Spam-Flag: NO X-Spam-Score: 0.00 RT-Send-Cc: X-RT-Original-Encoding: us-ascii Content-Length: 615 On Aug 20, 2008, at 15:38, Ezra Peisach via RT wrote: > Detected with the development version of valgrind in which helgrind > actually works. Yeah, I was looking at that in the context of a NetBSD build that was reporting errors; the NetBSD thread support does these sorts of checks automatically and blows up if you mess it up. I was going to change "&&" to "||" but adding "!" works too. :) (Weirdly enough, though, the build *stopped* failing when we fixed a bug in the snapshot process and started testing today's code instead of something from last month. I'm not sure what's up with that.) Ken