MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Message-ID: <DB2F9084-6D77-45DA-8FFA-B0CA9F4CCD9C@apple.com>
From: Love H?rnquist ?strand <lha@apple.com>
To: Zhanna Tsitkova via RT <rt-comment@krbdev.mit.edu>
In-Reply-To: <rt-6284-29981.0.43176724218192@krbdev.mit.edu>
Subject: Re: [krbdev.mit.edu #6284] memory leaks in error conditions
Date: Thu, 22 Jan 2009 16:21:47 -0800
References: <rt-6284-29981.0.43176724218192@krbdev.mit.edu>
RT-Send-Cc: 
Content-Length: 863


22 jan 2009 kl. 11.10 skrev Greg Hudson via RT:

> First patch looks fine; I adapted it to the current code (which was
> changed fairly heavily by Luke) and will commit shortly.
>
> I don't understand the second patch.  The first hunk appears to be for
> Apple-specific code, so I'm ignoring that.  The other hunks move a
> free(reply.enc_part.ciphertext.data) into the errorout label.  But (a)
> that move seems unnecessary, since in the old location the data was
> freed immediately after it was allocated (i.e. on successful return  
> from
> krb5_encode_kdc_rep), and (b) that move seems incorrect, since "goto
> errout" can happen in cases where reply.enc_part.ciphertext.data  
> hasn't
> been initialized.

There needs to be an if(reply.enc_part.ciphertext.data) protecting.

The reason we need this is that the pws case add an extra goto errout;

Love