Return-Path: Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (Postfix) with ESMTP id 9FDEFCCE6D; Thu, 8 Oct 2009 22:03:00 +0000 (UTC) Received: from pch.mit.edu (pch.mit.edu [127.0.0.1]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id n98M2xid010679; Thu, 8 Oct 2009 18:03:00 -0400 Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.7.7.76]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id n98LIJiC002937 for ; Thu, 8 Oct 2009 17:18:19 -0400 Received: from mit.edu (W92-130-BARRACUDA-3.MIT.EDU [18.7.21.224]) by fort-point-station.mit.edu (8.13.6/8.9.2) with ESMTP id n98LH9CA026923 for ; Thu, 8 Oct 2009 17:17:09 -0400 (EDT) Received: from outbound.mse3.exchange.ms (localhost [127.0.0.1]) by mit.edu (Spam Firewall) with ESMTP id BB22B14877C9 for ; Thu, 8 Oct 2009 17:17:08 -0400 (EDT) Received: from outbound.mse3.exchange.ms (outbound.mse3.exchange.ms [69.25.50.242]) by mit.edu with ESMTP id LwWdcInbyWHEgbFt for ; Thu, 08 Oct 2009 17:17:08 -0400 (EDT) X-Mimeole: Produced By Microsoft Exchange V6.5 Content-Class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: krb5 1.7 memory leak Date: Thu, 8 Oct 2009 17:17:01 -0400 Message-ID: <23447137FA0DAA4D95EF535FF356BE46034BB8EC@mse3be2.mse3.exchange.ms> X-MS-Has-Attach: X-MS-Tnef-Correlator: Thread-Topic: krb5 1.7 memory leak Thread-Index: AcpIXK0STo0xmeb6QYKzDG1tiqzfGg== From: "Arlene Berry" To: X-Spam-Score: 0.02 X-Spam-Flag: NO X-Scanned-BY: MIMEDefang 2.42 Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by pch.mit.edu id n98LIJiC002937 X-Mailman-Approved-At: Thu, 08 Oct 2009 17:48:48 -0400 X-Beenthere: krb5-bugs-incoming@mailman.mit.edu X-Mailman-Version: 2.1.6 Precedence: list Sender: krb5-bugs-incoming-bounces@PCH.mit.edu Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu X-RT-Original-Encoding: us-ascii Content-Length: 1218 The enc_padata field that was added to the krb5_enc_kdc_rep_part structure for 1.7 is being leaked. Our fix is below. It looks like the second change was done in trunk when the S4U changes were merged. Modified: src/lib/krb5/asn.1/asn1_k_decode.c =================================================================== --- src/lib/krb5/asn.1/asn1_k_decode.c 2009-10-07 22:25:00 UTC (rev 37774) +++ src/lib/krb5/asn.1/asn1_k_decode.c 2009-10-07 22:27:28 UTC (rev 37775) @@ -668,6 +668,7 @@ krb5_free_last_req(NULL, val->last_req); krb5_free_principal(NULL, val->server); krb5_free_addresses(NULL, val->caddrs); + krb5_free_pa_data(NULL, val->enc_padata); val->session = NULL; val->last_req = NULL; val->server = NULL; Modified: src/lib/krb5/krb/kfree.c =================================================================== --- src/lib/krb5/krb/kfree.c 2009-10-07 22:25:00 UTC (rev 37774) +++ src/lib/krb5/krb/kfree.c 2009-10-07 22:27:28 UTC (rev 37775) @@ -297,6 +297,7 @@ krb5_free_last_req(context, val->last_req); krb5_free_principal(context, val->server); krb5_free_addresses(context, val->caddrs); + krb5_free_pa_data(context, val->enc_padata); free(val); }