Return-Path: Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (Postfix) with ESMTP id 6367B3E6EC; Mon, 11 Jan 2010 15:08:28 -0500 (EST) Received: from pch.mit.edu (pch.mit.edu [127.0.0.1]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id o0BK8S2R027453; Mon, 11 Jan 2010 15:08:28 -0500 Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.7.7.76]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id o0BJZj30021996 for ; Mon, 11 Jan 2010 14:35:45 -0500 Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU [18.9.25.12]) by fort-point-station.mit.edu (8.13.6/8.9.2) with ESMTP id o0BJYb6V018191 for ; Mon, 11 Jan 2010 14:36:02 -0500 (EST) X-Auditid: 1209190c-b7ccdae00000276b-2f-4b4b7d8dd12d Received: from tombraider.mr.itd.umich.edu (smtp.mail.umich.edu [141.211.93.161]) by dmz-mailsec-scanner-1.mit.edu (Symantec Brightmail Gateway) with SMTP id 73.44.10091.D8D7B4B4; Mon, 11 Jan 2010 14:35:41 -0500 (EST) Received: FROM arbl-rsug103.staff.itd.umich.edu (arbl-rsug103.staff.itd.umich.edu [141.213.231.103]) By tombraider.mr.itd.umich.edu ID 4B4B7D8B.3974D.4295 ; Authuser pturgyan; 11 Jan 2010 14:35:39 EST Message-ID: <9CA2A27A-FACB-4E47-B81E-3F1350E853C2@umich.edu> From: Paul Turgyan To: krb5-bugs@mit.edu Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit MIME-Version: 1.0 (Apple Message framework v936) Subject: Memory leak when environment variable KRB5RCACHETYPE=none Date: Mon, 11 Jan 2010 14:35:39 -0500 X-Mailer: Apple Mail (2.936) X-Brightmail-Tracker: AAAAAQDGA3E= X-Mailman-Approved-At: Mon, 11 Jan 2010 15:08:03 -0500 X-Beenthere: krb5-bugs-incoming@mailman.mit.edu X-Mailman-Version: 2.1.6 Precedence: list Sender: krb5-bugs-incoming-bounces@PCH.mit.edu Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu X-RT-Original-Encoding: us-ascii Content-Length: 795 When the replay cache is set to "none" using the environment variable KRB5RCACHETYPE=none a memory leak occurs. This was detected when using OpenLDAP, Cyrus- SASL, and GSSAPI authentication. The following patch fixes the problem diff -ur krb5-1.6.3/src/lib/krb5/krb/srv_rcache.c krb5-1.6.3um1/src/ lib/krb5/krb /srv_rcache.c *** krb5-1.6.3/src/lib/krb5/krb/srv_rcache.c Fri Jun 30 01:59:46 2006 --- krb5-1.6.3um1/src/lib/krb5/krb/srv_rcache.c Mon Dec 7 16:19:02 2009 *************** *** 54,59 **** --- 54,64 ---- cachetype = krb5_rc_default_type(context); + if (strncmp (cachetype, "none", 4) == 0) { + *rcptr = 0; + return 0; + } + len = piece->length + 3 + 1; for (i = 0; i < piece->length; i++) { if (piece->data[i] == '-')