Return-Path: Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (Postfix) with ESMTP id 3E7B83F0F3; Fri, 5 Mar 2010 00:41:19 -0500 (EST) Received: from pch.mit.edu (pch.mit.edu [127.0.0.1]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id o255fJYm000324; Fri, 5 Mar 2010 00:41:19 -0500 Received: from mailhub-dmz-4.mit.edu (MAILHUB-DMZ-4.MIT.EDU [18.7.62.38]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id o231p8dm013285 for ; Tue, 2 Mar 2010 20:51:08 -0500 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU [18.9.25.14]) by mailhub-dmz-4.mit.edu (8.13.8/8.9.2) with ESMTP id o231otBt000644 for ; Tue, 2 Mar 2010 20:51:08 -0500 X-Auditid: 1209190e-b7bbeae000000d46-b1-4b8dc08b71c7 Received: from sh2.exchange.ms (sh2.exchange.ms [64.71.238.64]) by dmz-mailsec-scanner-3.mit.edu (Symantec Brightmail Gateway) with SMTP id 4F.D9.03398.B80CD8B4; Tue, 2 Mar 2010 20:51:07 -0500 (EST) Received: from outbound.mse3.exchange.ms (unknown [10.0.25.203]) by sh2.exchange.ms (Postfix) with ESMTP id 85DF03D8033 for ; Tue, 2 Mar 2010 20:50:30 -0500 (EST) X-Mimeole: Produced By Microsoft Exchange V6.5 Content-Class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: memory leak in SPNEGO Date: Tue, 2 Mar 2010 20:50:21 -0500 Message-ID: <23447137FA0DAA4D95EF535FF356BE46041548FF@mse3be2.mse3.exchange.ms> X-MS-Has-Attach: X-MS-Tnef-Correlator: Thread-Topic: memory leak in SPNEGO Thread-Index: Acq6c+Jq1a70R7xPSfiCx7As3vMMCw== From: "Arlene Berry" To: X-Brightmail-Tracker: AAAAAA== Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by pch.mit.edu id o231p8dm013285 X-Mailman-Approved-At: Fri, 05 Mar 2010 00:41:18 -0500 X-Beenthere: krb5-bugs-incoming@mailman.mit.edu X-Mailman-Version: 2.1.6 Precedence: list Sender: krb5-bugs-incoming-bounces@PCH.mit.edu Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu X-RT-Original-Encoding: us-ascii Content-Length: 792 We caught a memory leak in SPNEGO. This fixed it for us: Index: src/lib/gssapi/spnego/spnego_mech.c =================================================================== --- src/lib/gssapi/spnego/spnego_mech.c (revision 23762) +++ src/lib/gssapi/spnego/spnego_mech.c (working copy) @@ -1739,9 +1739,12 @@ } if (ret == GSS_S_COMPLETE) { *context_handle = (gss_ctx_id_t)sc->ctx_handle; - if (sc->internal_name != GSS_C_NO_NAME && - src_name != NULL) { + if (sc->internal_name != GSS_C_NO_NAME) { + if (src_name != NULL) { *src_name = sc->internal_name; + } else { + gss_release_name(&tmpmin, &sc->internal_name); + } } release_spnego_ctx(&sc); } else if (ret != GSS_S_CONTINUE_NEEDED) {