Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) From: tlyu@mit.edu Subject: SVN Commit RT-Send-CC: X-RT-Original-Encoding: iso-8859-1 Content-Length: 1209 pull up r24639, r24641 from trunk ------------------------------------------------------------------------ r24641 | ghudson | 2011-02-18 07:06:57 -0800 (Fri, 18 Feb 2011) | 7 lines ticket: 6869 Fix a conceptual bug in r24639: the intermediate key container length should be the hash's output size, not its block size. (The bug did not show up in testing because it is harmless in practice; MD5 has a larger block size than output size.) ------------------------------------------------------------------------ r24639 | ghudson | 2011-02-16 14:52:41 -0800 (Wed, 16 Feb 2011) | 11 lines ticket: 6869 subject: hmac-md5 checksum doesn't work with DES keys target_version: 1.9 tags: pullup krb5int_hmacmd5_checksum calculates an intermediate key using an HMAC. The container for this key should be allocated using the HMAC output size (which is the hash blocksize), not the original key size. This bug was causing the function to fail with DES keys, which can be used with hmac-md5 in PAC signatures. https://github.com/krb5/krb5/commit/3884808c126d5081a3051040e162410d20b4c89d Commit By: tlyu Revision: 24643 Changed Files: U branches/krb5-1-9/src/lib/crypto/krb/checksum/hmac_md5.c