Return-Path: <krb5-bugs-incoming-bounces@PCH.mit.edu>
Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (Postfix) with ESMTP id 9CCB73DC26; Sat, 10 Sep 2011 09:10:02 -0400 (EDT)
Received: from pch.mit.edu (pch.mit.edu [127.0.0.1]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id p8AD9xiA003051; Sat, 10 Sep 2011 09:09:59 -0400
Received: from mailhub-dmz-4.mit.edu (MAILHUB-DMZ-4.MIT.EDU [18.7.62.38]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id p8AD9sRW003023 for <krb5-bugs-incoming@PCH.mit.edu>; Sat, 10 Sep 2011 09:09:54 -0400
Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU [18.7.68.35]) by mailhub-dmz-4.mit.edu (8.13.8/8.9.2) with ESMTP id p8AD9sQT001338 for <krb5-bugs@mit.edu>; Sat, 10 Sep 2011 09:09:54 -0400
X-Auditid: 12074423-b7b31ae000000a3c-e1-4e6b61a32edd
Authentication-Results: symauth.service.identifier
Received: from mail.suchdamage.org (permutation-city.suchdamage.org [69.25.196.28]) by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP id 76.0B.02620.3A16B6E4; Sat, 10 Sep 2011 09:09:55 -0400 (EDT)
Received: from carter-zimmerman.suchdamage.org (carter-zimmerman.suchdamage.org [69.25.196.178]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "laptop", Issuer "laptop" (not verified)) by mail.suchdamage.org (Postfix) with ESMTPS id 1EDB5202FB for <krb5-bugs@mit.edu>; Sat, 10 Sep 2011 09:11:52 -0400 (EDT)
Received: by carter-zimmerman.suchdamage.org (Postfix, from userid 8042) id 1347042B7; Sat, 10 Sep 2011 09:09:51 -0400 (EDT)
To: krb5-bugs@MIT.EDU
Subject: cms_signeddata_verify has unsafe error handling
Message-ID: <20110910130951.1347042B7@carter-zimmerman.suchdamage.org>
Date: Sat, 10 Sep 2011 09:09:51 -0400 (EDT)
From: hartmans@MIT.EDU (Sam Hartman)
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRWlGSWpSXmKPExsXiKnlERndxYrafwfzFRhYND4+zOzB6NJ05 yhzAGMVlk5Kak1mWWqRvl8CV8WzXe7aC/6wVh/ZsYGxg/MvcxcjJISFgIrHq1XZ2EJtRwEhi 97lXrBBxMYkL99azdTFycQgJ3GGUONTYxgzhXGaS6Gg/CFYlJFAn8a11AROILSIgKvHy7zEW EFtYwEJi4+rrYDW8Am4SrZfvgNksAtoSt7ZuBNvGJqAisWbBGfYJjNwLGBlWMcqm5Fbp5iZm 5hSnJusWJyfm5aUW6Zrp5WaW6KWmlG5iBHpViN1FeQfjn4NKhxgFOBiVeHhXmmb5CbEmlhVX 5h5ilORgUhLlZY3P9hPiS8pPqcxILM6ILyrNSS0+xCjBwawkwjtHCSjHm5JYWZValA+TkuZg URLnldnp4CckkJ5YkpqdmlqQWgSTZeJgP8Qow8GhJMGrBgxjIcGi1PTUirTMnBJkNZwgggtk DQ/QmusgJ/AWFyTmFmemQxSdYlSUEuf9lwCUEABJZJTmwQ2AReIlRlkpYV5GBgYGIR6gC4Ae R5V/xSgO9LQwLxPIHTyZeSVw018BLWYCWhywPRNkcUkiQkqqgXFDaeeXUKesJUuePambeO3L XfnuB1lmJbINFml/Vn/4ErrR/nDLP6efTQu1jJ2/v5diiF/ltFfyze5wrT2HQ+vsdipWPJD4 1KayoiXmNEt/8aMTfL82R6xTmOpjNTvHMF+v0zen/U/NY63wBba6oQaSUQ+l2X7GHQzJNFuq wDTbXfDezL/r1ZVYijMSDbWYi4oTAauzWfC/AgAA
X-Beenthere: krb5-bugs-incoming@mailman.mit.edu
X-Mailman-Version: 2.1.6
Precedence: list
Sender: krb5-bugs-incoming-bounces@PCH.mit.edu
Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu
X-RT-Original-Encoding: iso-8859-1
Content-Length: 756


I felt the need to add the following comment to cms_signeddata_verify

    /*                                                                          
     * Warning: Since most openssl functions do not set retval, large chunks of
     * this function assume that retval is always a failure and may go to       
     * cleanup without setting retval explicitly. Make sure retval is not set   
     * to 0 or errors such as signature verification failure may be converted   
     * to success with significant security consequences.                       

If anyone accidentally inserted a k5alloc or anything else that set retval, it would be really bad.
I'd recommend refactoring that function.
Since I'm not doing that now I'm opening a bug to track.