Return-Path: Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (Postfix) with ESMTP id 9AF1E3EBB9; Tue, 25 Sep 2012 17:15:17 -0400 (EDT) Received: from pch.mit.edu (pch.mit.edu [127.0.0.1]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id q8PLFFmd018110; Tue, 25 Sep 2012 17:15:15 -0400 Received: from mailhub-dmz-2.mit.edu (MAILHUB-DMZ-2.MIT.EDU [18.7.62.37]) by pch.mit.edu (8.13.6/8.12.8) with ESMTP id q8PLDScO017771 for ; Tue, 25 Sep 2012 17:13:28 -0400 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU [18.7.68.34]) by mailhub-dmz-2.mit.edu (8.13.8/8.9.2) with ESMTP id q8PLBvlP008686 for ; Tue, 25 Sep 2012 17:13:28 -0400 X-Auditid: 12074422-b7f746d0000008cc-14-50621e787429 Authentication-Results: symauth.service.identifier Received: from homiemail-a88.g.dreamhost.com (caiajhbdcbbj.dreamhost.com [208.97.132.119]) by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP id BC.82.02252.87E12605; Tue, 25 Sep 2012 17:13:28 -0400 (EDT) Received: from homiemail-a88.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a88.g.dreamhost.com (Postfix) with ESMTP id B86C2264059 for ; Tue, 25 Sep 2012 14:13:27 -0700 (PDT) Dkim-Signature: v=1; a=rsa-sha1; c=relaxed; d=cryptonector.com; h= mime-version:date:message-id:subject:from:to:content-type; s= cryptonector.com; bh=Iy+Zaiawe/UcEoCMXig17+c6HF4=; b=SyFJNBK9v9c rFjASUh9/QQNIotf+AUSBWXmVFlKJl+1RNj2m51iO4pzuJB0mImuLE0apbIn77f/ I/NiDzWwfrYC0ENbw3FbxUnMeFpXvP9UTKEjBzGU7wgoQYLGPAvTh7XpoI1jSjip WS8rqgvzXeZM809E5JxCiLr58xdjwd6A= Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: nico@cryptonector.com) by homiemail-a88.g.dreamhost.com (Postfix) with ESMTPSA id 9805E26404E for ; Tue, 25 Sep 2012 14:13:27 -0700 (PDT) Received: by pbbrq8 with SMTP id rq8so809410pbb.36 for ; Tue, 25 Sep 2012 14:13:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.75.133 with SMTP id c5mr44163002paw.24.1348607607139; Tue, 25 Sep 2012 14:13:27 -0700 (PDT) Received: by 10.68.20.194 with HTTP; Tue, 25 Sep 2012 14:13:27 -0700 (PDT) Date: Tue, 25 Sep 2012 16:13:27 -0500 Message-ID: Subject: MAX_ULOGENTRIES is too low From: Nico Williams To: krb5-bugs@mit.edu Content-Type: text/plain; charset=UTF-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRWlGSWpSXmKPExsVyIbGlXLdCLinAYMF9DYuGh8fZHRg9ms4c ZQ5gjOKySUnNySxLLdK3S+DKOLyptKCHs2LFhcXMDYyH2boYOTkkBEwkJq5Yxw5iMwoYSew+ 94oVIi4mceHeeqAaLg4hgceMEt83tzFCOGcYJfrbtrOAOCwC75kkli5eyQSRecgk0dJygwWk X0igSuLe9DOMIDavgKDEyZlPoOIFEhPftTBC2F4Sf1a0g8VZBFQlZn56wQZRHyDx7MVMsDuE BZQl5i76BHQfBwebgLbE5m2KIGERAVGJl3+PsYCEmQXUJdbPE5rAKDgLybJZCJkFjEyrGGVT cqt0cxMzc4pTk3WLkxPz8lKLdE31cjNL9FJTSjcxAgNSiN1FaQfjz4NKhxgFOBiVeHgPPE8M EGJNLCuuzD3EKMnBpCTK+0gqKUCILyk/pTIjsTgjvqg0J7X4EKMEB7OSCK8xSDlvSmJlVWpR PkxKmoNFSZz3WspNfyGB9MSS1OzU1ILUIpgsEwf7IUYZDg4lCd5GWaDJgkWp6akVaZk5Jchq OEEEF8gaHqA1OSCFvMUFibnFmekQRacYjTk+nlzwgJHj0sfFDxiFWPLy81KlxHkzQEoFQEoz SvPgRsISzSVGWSlhXkYGBgYhHqCbgEGBKv+KURwYDMK8y0Cm8GTmlcDtewV0ChPQKfx74kBO KUlESEk1MCZrHzu5cvtV3pnyu/bU95auszPbIvWUQ07aa6L91/+7OuymcXCo+Sg/4alXujJb gUt56Zz1EcYJZvLMUVsVspkCGnapsqkeMkgzrKo83NJ41tbDr/puNsMlxwt9H7MTKk6u5vJ8 m5VRPTXRSv6pbIGpfdgWNe2iPNXQ43/U9syePzFJ3CtdiaU4I9FQi7moOBEA1uK/+i8DAAA= X-Mailman-Approved-At: Tue, 25 Sep 2012 17:15:15 -0400 X-Beenthere: krb5-bugs-incoming@mailman.mit.edu X-Mailman-Version: 2.1.6 Precedence: list Sender: krb5-bugs-incoming-bounces@PCH.mit.edu Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu Content-Length: 1132 There's no reason to have a maximum on the number of entries in the iprop ulog. This should just be removed. diff --git a/src/include/kdb_log.h b/src/include/kdb_log.h index beecdc1..c8d0288 100644 --- a/src/include/kdb_log.h +++ b/src/include/kdb_log.h @@ -53,7 +53,6 @@ extern "C" { /* * Default ulog file attributes */ -#define MAX_ULOGENTRIES 2500 #define DEF_ULOGENTRIES 1000 #define ULOG_IDLE_TIME 10 /* in seconds */ /* diff --git a/src/lib/kadm5/alt_prof.c b/src/lib/kadm5/alt_prof.c index d218640..b18bbd5 100644 --- a/src/lib/kadm5/alt_prof.c +++ b/src/lib/kadm5/alt_prof.c @@ -822,9 +822,7 @@ krb5_error_code kadm5_get_config_params(context, use_kdc_config, } else { if (aprofile && !krb5_aprof_get_int32(aprofile, hierarchy, TRUE, &ivalue)) { - if (ivalue > MAX_ULOGENTRIES) - params.iprop_ulogsize = MAX_ULOGENTRIES; - else if (ivalue <= 0) + if (ivalue <= 0) params.iprop_ulogsize = DEF_ULOGENTRIES; else params.iprop_ulogsize = ivalue;