Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) From: tlyu@mit.edu Subject: SVN Commit X-RT-Original-Encoding: iso-8859-1 Content-Length: 763 Avoid side effects in assert expressions asserts may be compiled out with -DNDEBUG, so it's wrong to use an assert expression with an important side effect. (We also have scores of side-effecting asserts in test programs, but those are less important and can be dealt with separately.) (cherry picked from commit 221cd4a23691601a14500bc00146c265b50bdc94) https://github.com/krb5/krb5/commit/4a5475fe5969a529e4bc9892dc2f7e17c0b6d685 Author: Greg Hudson Committer: Tom Yu Commit: 4a5475fe5969a529e4bc9892dc2f7e17c0b6d685 Branch: krb5-1.10 src/lib/apputils/net-server.c | 5 ++++- src/lib/crypto/krb/cf2.c | 3 ++- src/util/et/com_err.c | 12 ++++++++---- 3 files changed, 14 insertions(+), 6 deletions(-)