Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.411 (Entity 5.404) X-RT-Original-Encoding: iso-8859-1 Content-Length: 2376 From bjaspan@MIT.EDU Thu Nov 7 15:15:09 1996 Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id PAA26605 for ; Thu, 7 Nov 1996 15:15:08 -0500 Received: from DUN-DUN-NOODLES.MIT.EDU by MIT.EDU with SMTP id AA16505; Thu, 7 Nov 96 15:15:07 EST Received: by DUN-DUN-NOODLES.MIT.EDU (5.x/4.7) id AA14256; Thu, 7 Nov 1996 15:15:04 -0500 Message-Id: <9611072015.AA14256@DUN-DUN-NOODLES.MIT.EDU> Date: Thu, 7 Nov 1996 15:15:04 -0500 From: "Barry Jaspan" To: krb5-bugs@MIT.EDU Subject: [daemon@ATHENA.MIT.EDU : memory leak in kdb_cpw.c] >Number: 163 >Category: krb5-kdc >Synopsis: memory leak in kdb_cpw.c >Confidential: yes >Severity: serious >Priority: medium >Responsible: krb5-unassigned >State: closed >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Thu Nov 07 15:16:01 EST 1996 >Last-Modified: Mon Nov 11 17:07:13 EST 1996 >Originator: >Organization: >Release: >Environment: >Description: >How-To-Repeat: >Fix: >Audit-Trail: Responsible-Changed-From-To: gnats-admin->krb5-unassigned Responsible-Changed-By: tlyu Responsible-Changed-When: Thu Nov 7 16:42:27 1996 Responsible-Changed-Why: Refiling State-Changed-From-To: open-closed State-Changed-By: bjaspan State-Changed-When: Mon Nov 11 17:06:59 1996 State-Changed-Why: Fixed. Files: lib/kdb/ChangeLog lib/kdb/kdb_cpw.c >Unformatted: ------- Forwarded transaction [1943] daemon@ATHENA.MIT.EDU (Barry Jaspan) Kerberos-V5-bugs 05/30/96 18:05 (17 lines) Subject: memory leak in kdb_cpw.c Date: Thu, 30 May 96 18:05:29 -0400 From: "Barry Jaspan" To: krb5-bugs@MIT.EDU krb5_decode_princ_contents (kdb_xdr.c:610) allocates an array of krb5_key_data structures in the krb5_db_entry that it returns. krb5_dbe_crk, and its relatives, alter the contents of that array when changing the db_entry's keys. The functions all call cleanup_key_data to free the *contents* of the old keys that are removed from the db_entry, but cleanup_key_data does not free the array of krb5_key_data structures itself. cleanup_key_data is a static function inside kdb_cpw.c. We simply need to verify that all callers expect it to free the key_data array and then add the free() call to that function. --[1943]-- ------- End forwarded transaction