Return-Path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by krbdev.mit.edu (Postfix) with ESMTPS id 9E2F258641 for ; Thu, 29 Sep 2016 14:59:13 -0400 (EDT) Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8TIx9mw012519 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Sep 2016 18:59:12 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u8TIx9re018024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Sep 2016 18:59:09 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u8TIx6m8013084 for ; Thu, 29 Sep 2016 18:59:08 GMT Received: from oracle.com (/10.135.188.58) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 29 Sep 2016 11:59:06 -0700 Date: Thu, 29 Sep 2016 13:59:05 -0500 From: Will Fiveash To: rt@krbdev.mit.edu Subject: Re: [krbdev.mit.edu #8502] ret_boolean in profile_get_boolean() should be krb5_boolean * instead of int * Message-ID: <20160929185905.GE19265@oracle.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2+29,mq+4 (8bebfd8902ec) (2016-07-01) X-Source-Ip: userv0021.oracle.com [156.151.31.71] RT-Send-Cc: X-RT-Original-Encoding: us-ascii Content-Length: 441 Actually, there is only one call to profile_get_boolean() in use_dns_uri() that needs a cast: ret = profile_get_boolean(ctx->profile, KRB5_CONF_LIBDEFAULTS, KRB5_CONF_DNS_URI_LOOKUP, NULL, DEFAULT_URI_LOOKUP, (int *)&use); ^^^^^^^ and everything else compiles without error. -- Will Fiveash Oracle Solaris Software Engineer