From erik.sjolund@gmail.com Tue Apr 24 17:20:34 2018 Return-Path: Received: from mail-io0-f195.google.com (mail-io0-f195.google.com [209.85.223.195]) by krbdev.mit.edu (Postfix) with ESMTPS id 126F6441E0; Tue, 24 Apr 2018 17:20:34 -0400 (EDT) Received: by mail-io0-f195.google.com with SMTP id y128-v6so24430725iod.4; Tue, 24 Apr 2018 14:20:33 -0700 (PDT) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z4romtWv0GR4r5wWV6RakJZA2xdJHK2D27W/YRCks+Q=; b=tsWOI1aTfH9rmS1EpDgcRy1ww7UmQWxPbw08X2JOoYrPJqO2XMNtWB6SlolvB11odk rmA4mxbiKHnvlkcJB2yNyw6b2RIpez/+qQZEl1oGBJZDR4TPbazRUnwjDscIwoDlMonh ieiDs3g97ufHGwo86+hkEkYOEJ46afQ3czJqNh51bd0xL40ianOQhgXcBk9onxYdIf9w Q65rB0R1Ls/TjmjFcSj+nujKushwahx2f41a9wlckvjMDsLb9n50iMb67UQVeqAg9+fS fL/RJHTF9HeJrkR/BBtTRHt/86aJ7B5BEKq3KqKBLVmkq1orcRAYK4s3YwPQs37Jdvxd Kqaw== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z4romtWv0GR4r5wWV6RakJZA2xdJHK2D27W/YRCks+Q=; b=ebzdhqxJ9oRd+yGN/6TG9gc7iR2ReNVtjeKSrgSZ3G5J9P/+MPcSl6Scr3xD74nduQ /U0GB1I6t2WIO8KA38Zou0mewqFJ6OZUZFfjXdmHGKt65jx0Bgn7o8tkewxIJ3yJgD18 xNs9kdSOCYCPivVdqiANOhc/p04ctebamHZwqxZtIST/ZNHpsdeVzpozsIvG8RNmKq5I SoKAKifloOBpwn6IgHhxdAmS2bNqs0D5zn+dYirkg6KavTx0r/LfK4w+WpYilU7cOEgH imFEhUN8zIfmbpF+z+pCQFU+iAgdKeCwGopXwB6T5R0jtHUiBhChjA0ffIoupjWS95K2 HSXw== X-GM-Message-State: ALQs6tDkPZdqisIJcpXodX3AjzAQ3Te92q9gkKwcRqkFpGHCx6cp9a9+ H8kjkcXmCv2S9fNeRKatvcH4yZj/u+7WRgOWAVx4cw== X-Google-SMTP-Source: AIpwx49vQ5tQGfpKrLUbJk9TegQQ3zqEWMT9YgB5yNdDREa/dJimgRrxIcuOtv09bMxNZqqKnYt9vs7niqCPw31kAmY= X-Received: by 2002:a6b:ad44:: with SMTP id w65-v6mr26910677ioe.211.1524604832889; Tue, 24 Apr 2018 14:20:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:f7db:0:0:0:0:0 with HTTP; Tue, 24 Apr 2018 14:20:32 -0700 (PDT) In-Reply-To: References: From: Erik Sjölund Date: Tue, 24 Apr 2018 23:20:32 +0200 Message-ID: Subject: Re: [krbdev.mit.edu #8661] git commit To: rt-comment@krbdev.mit.edu, rt@krbdev.mit.edu CC: taviso@google.com Content-Type: text/plain; charset="UTF-8" RT-Send-Cc: Content-Length: 872 A comment regarding the git commit: https://github.com/krb5/krb5/commit/c5b0a998d6349f8c90821a347db5666aed0e50eb The check for argc == 0 happens after the first use of argv[0]. Why not place the if statement right in the start of main()? On Tue, Apr 24, 2018 at 10:10 PM, Greg Hudson via RT wrote: > > Check for zero argc in ksu > > Most programs in the tree will perform a null dereference when argc is > zero, but as a setuid program ksu should be extra careful about memory > errors, even if this one is harmless. Check and exit with status 1 > immediately. > > https://github.com/krb5/krb5/commit/c5b0a998d6349f8c90821a347db5666aed0e50eb > Author: Greg Hudson > Commit: c5b0a998d6349f8c90821a347db5666aed0e50eb > Branch: master > src/clients/ksu/main.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) >