X-Originatororg: mitprod.onmicrosoft.com X-MS-Oob-TLC-Oobclassifiers: OLM:1201; Arc-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwE5pDnZGqv719Mp7xBG1J1knjaWTbLdYO6zniV53ig=; b=Oz17PaXzAoWDAZ+vSh51iEgA965gHEWeN5gxdGyoQUwb6Y81BnsOjvOOnR2h8veXv0mqPYxANBDzdE+v5Yd5UYc8omkl4nfEyCo+HZVge3cXhD8WEBYwtsXCe8x5n25lx6WfvyyC8wAvGO4aBQ97Q9nTqzDbX6al/tX4vcneeZslhKFnvaJPseR07laqrGvrDNDWoB9BECBpVVNBp2eBszYv6cov9jEXzhncXKnTcDZl3HNZ+SdpcE3Pbcadi9Ht07tr0UvYhoMI+z57ma7PfJA7HQN6RHZdsQTDBQB2yyY/xR2vtjRMvOIGH2G9a0fy+SZrF3wM7oBX7WkSTNOkZQ== X-Eopattributedmessage: 0 Precedence: list Arc-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none X-MS-Exchange-Crosstenant-Originalarrivaltime: 24 Mar 2020 15:46:18.5952 (UTC) X-Forefront-Antispam-Report: CIP:195.135.220.15; IPV:; CTRY:DE; EFV:NLI; SFV:NSPM; SFS:(10019020)(4636009)(376002)(39860400002)(346002)(136003)(396003)(26005)(34206002)(498600001)(31686004)(8676002)(36756003)(31696002)(86362001)(5660300002)(7636002)(70586007)(7596002)(68406010)(2906002)(316002)(6266002)(786003)(246002)(2616005)(336012)(356004)(956004); DIR:OUT; SFP:1102; SCL:1; SRVR:MW2PR0102MB3515; H:mx2.suse.de; FPR:; SPF:Pass; LANG:en; PTR:mx2.suse.de; X-Beenthere: krb5-bugs-incoming@mailman.mit.edu content-type: text/plain; charset="utf-8" Sender: krb5-bugs-incoming-bounces@PCH.mit.edu X-Auto-Response-Suppress: DR, OOF, AutoReply Date: Tue, 24 Mar 2020 16:46:16 +0100 X-MS-Exchange-Transport-Crosstenantheadersstamped: MW2PR0102MB3515 Content-Transfer-Encoding: 7bit Received-SPF: Pass (protection.outlook.com: domain of suse.cz designates 195.135.220.15 as permitted sender) receiver=protection.outlook.com; client-ip=195.135.220.15; helo=mx2.suse.de; X-Mailman-Version: 2.1.6 Subject: krb5 crashes in k5_primary_domain X-Microsoft-Antispam: BCL:0; From: "Jiri Slaby" X-Mailman-Approved-At: Tue, 24 Mar 2020 13:27:55 -0400 X-MS-Exchange-Crosstenant-ID: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y X-MS-Exchange-Crosstenant-Fromentityheader: Internet X-Eoptenantattributedmessage: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b:0 Authentication-Results: spf=pass (sender IP is 195.135.220.15) smtp.mailfrom=suse.cz; mit.edu; dkim=none (message not signed) header.d=none;mit.edu; dmarc=bestguesspass action=none header.from=suse.cz;compauth=pass reason=109 Errors-To: krb5-bugs-incoming-bounces@PCH.mit.edu Return-Path: X-Virus-Scanned: by amavisd-new at test-mx.suse.de X-MS-Exchange-Transport-Forked: True X-LD-Processed: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b,ExtAddr X-MS-Traffictypediagnostic: MW2PR0102MB3515: To: krb5-bugs@mit.edu X-MS-Exchange-Atpmessageproperties: SA X-MS-Exchange-Crosstenant-Network-Message-ID: f270783f-541f-46a6-54ff-08d7d00a7ea6 X-Forefront-PRVS: 03524FBD26 Message-ID: Arc-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LBd0nMrO0Wa7qg7+9lZ7MioCavqV28t9OK8MUtdljWm8RWHynWekie65nzv0L+UCWJzZyou993hdgSgbIMpt/XofwhbGQFQH5igjHBR70gjoqzPgQCf74IgPbScbNDeUfTf+9rj3QAAP5kqVdhfxtCmniTQ6g/2vu7iVFIOQzME/QhIIhe/GLB6M5IBLa09qyV/qbLNYbzld7adGw5i4+VkWmHZI+V3ntOTHsJYsEei61lsm34khQiEOIGdHmg8rZbXGccVptYHW4ph08TK//vGvtpIxzXPW6qbO3n/eXK8/SvcOeSt1D0P89lbhbYgHj56R2ZeWWKkDDOp919u+5w== X-RT-Incoming-Encryption: Not encrypted X-MS-Exchange-Senderadcheck: 0 From krb5-bugs-incoming-bounces@PCH.mit.edu Tue Mar 24 13:27:56 2020 X-MS-Publictraffictype: Email X-Microsoft-Antispam-PRVS: X-Microsoft-Antispam-Message-Info: LU+0L+d93iWPc07KVLzCw/lK8545PgjW70vH2pr1uOO+LCVWyldp+EWm18inyOn7nxlHBaDkXbu5A5AVFFBA/9H9/lhP1EsRp+PAyVaPfXX21MGCq1ZlMIP9r1qtfnywvk2t8MeqO8hD7eSyEtowFAOqC3/HP+ZDO+cNtU3NyyCoUSwi6d4YWRVSkqUCuS9lVukpa/IV8eVzDM+iP279J6Pb46LBv8Z3Zn8G3fQ8cVQtEtZrNB05x9tr2Uv2b/LcQKrPtnOnmYBrNE2bwU81yYvCf2NYFGvfGKeBRnYvO4Ru4Lb9j7WJp6IU5bX3q9a+nAtVGooQEfyobGpDn3leEJKdrO/SFFZNHGMZqs0lW+/TJja3VxO6+e8PgGjZBTWY2Lh6dxUgHWOTuvoHuUzAOc9A0jjBSm/au2vMuoyKJjfk1cu5C6WPeo8LCcduAjxEqv7iDZl5IHuLAfAWuIEybSk6xSsEgX9k6HBr+IomehSccTglyGM6HkX1c7wEbSk+EGP1L9ASJDhBbH+6pj0v22/QTfhdhQkxtbrgvzbEIAhBLpSZTP1iTFL1llf3bNF/ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-ID: f270783f-541f-46a6-54ff-08d7d00a7ea6 Content-Language: en-US Received: from PCH.mit.edu (PCH.MIT.EDU [18.7.21.50]) by krbdev.mit.edu (Postfix) with ESMTPS id 8DA4B4033D; Tue, 24 Mar 2020 13:27:56 -0400 (EDT) Received: from PCH.MIT.EDU (localhost.localdomain [127.0.0.1]) by PCH.mit.edu (8.14.7/8.12.8) with ESMTP id 02OHRueT027709; Tue, 24 Mar 2020 13:27:56 -0400 Received: from outgoing-exchange-1.mit.edu (OUTGOING-EXCHANGE-1.MIT.EDU [18.9.28.15]) by PCH.mit.edu (8.14.7/8.12.8) with ESMTP id 02OFkUhO013224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 24 Mar 2020 11:46:30 -0400 Received: from oc11exedge2.exchange.mit.edu (OC11EXEDGE2.EXCHANGE.MIT.EDU [18.9.3.18]) by outgoing-exchange-1.mit.edu (8.14.7/8.12.4) with ESMTP id 02OFkHkZ019212 for ; Tue, 24 Mar 2020 11:46:29 -0400 Received: from w92extsm1.exchange.mit.edu (18.7.74.52) by oc11exedge2.exchange.mit.edu (18.9.3.18) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 24 Mar 2020 11:46:08 -0400 Received: from oc11exhyb8.exchange.mit.edu (18.9.1.113) by w92extsm1.exchange.mit.edu (18.7.74.52) with Microsoft SMTP Server (TLS) id 15.0.1365.1; Tue, 24 Mar 2020 11:46:20 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by oc11exhyb8.exchange.mit.edu (18.9.1.113) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 24 Mar 2020 11:46:20 -0400 Received: from MWHPR22CA0058.namprd22.prod.outlook.com (2603:10b6:300:12a::20) by MW2PR0102MB3515.prod.exchangelabs.com (2603:10b6:302:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18; Tue, 24 Mar 2020 15:46:19 +0000 Received: from CO1NAM03FT018.eop-NAM03.prod.protection.outlook.com (2603:10b6:300:12a:cafe::c6) by MWHPR22CA0058.outlook.office365.com (2603:10b6:300:12a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.19 via Frontend Transport; Tue, 24 Mar 2020 15:46:19 +0000 Received: from mx2.suse.de (195.135.220.15) by CO1NAM03FT018.mail.protection.outlook.com (10.152.80.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.13 via Frontend Transport; Tue, 24 Mar 2020 15:46:18 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EBA96ACAE for ; Tue, 24 Mar 2020 15:46:16 +0000 (UTC) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mitprod.onmicrosoft.com; s=selector2-mitprod-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwE5pDnZGqv719Mp7xBG1J1knjaWTbLdYO6zniV53ig=; b=EZpb6lWwqMLIpwxfyGW8Cz5Ovath1NRVmxbKE8JgQBIZs107lg4O0mBPtT4XGDkTumqRsfBF/5h9iE0Y6aq4XA5E2j43gkXopOq04iw80SJIuCJ3hbqTLIXsDftFejc4vN2Lq/z4N5PXGny1CPfwRU+ssWmmmKvBkBHE5cPz11E= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 X-RT-Original-Encoding: iso-8859-2 X-RT-Interface: Email Content-Length: 4579 When no domain is set during bootup (but is set later), nfs invokes krb and nfs+krb crashes: > #0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:120 > #1 0x00007fe592ad7adf in __GI___strdup (s=0x0) at strdup.c:41 > #2 0x00007fe592903e89 in k5_primary_domain () at dnsglue.c:506 > #3 qualify_shortname (context=, host=0x7ffc8968f3d0 "anemoi") at sn2princ.c:74 > #4 k5_expand_hostname (context=context@entry=0x556b5f5bf5a0, host=host@entry=0x7ffc8968f3d0 "anemoi", is_fallback=is_fallback@entry=0, canonhost_out=canonhost_out@entry=0x7ffc8968f3b8) at sn2princ.c:128 > #5 0x00007fe592903eea in krb5_expand_hostname (context=context@entry=0x556b5f5bf5a0, host=host@entry=0x7ffc8968f3d0 "anemoi", canonhost_out=canonhost_out@entry=0x7ffc8968f3b8) at sn2princ.c:164 > #6 0x00007fe592906500 in krb5_sname_to_principal (context=0x556b5f5bf5a0, hostname=0x7ffc8968f3d0 "anemoi", hostname@entry=0x0, sname=sname@entry=0x556b5f5bdc80 "nfs", type=type@entry=3, princ_out=princ_out@entry=0x7ffc8968f488) > at sn2princ.c:219 > #7 0x00007fe592a111c3 in krb5_gss_import_name (minor_status=0x7ffc8969178c, input_name_buffer=, input_name_type=, output_name=0x7ffc89691690) at import_name.c:166 > #8 0x00007fe592a2a088 in gssint_import_internal_name (minor_status=minor_status@entry=0x7ffc8969178c, mech_type=mech_type@entry=0x556b5f5bcc70, union_name=union_name@entry=0x556b5f5a3a20, > internal_name=internal_name@entry=0x7ffc89691690) at g_glue.c:400 > #9 0x00007fe592a2b820 in gss_add_cred_from (minor_status=minor_status@entry=0x7ffc8969178c, input_cred_handle=, desired_name=desired_name@entry=0x556b5f5a3a20, desired_mech=, > cred_usage=cred_usage@entry=2, initiator_time_req=initiator_time_req@entry=4294967295, acceptor_time_req=4294967295, cred_store=0x0, output_cred_handle=0x0, actual_mechs=0x0, initiator_time_rec=0x0, acceptor_time_rec=0x0) > at g_acquire_cred.c:512 > #10 0x00007fe592a2de3f in gss_acquire_cred_from (minor_status=0x7ffc89691864, desired_name=0x556b5f5a3a20, time_req=4294967295, desired_mechs=0x0, cred_usage=2, cred_store=cred_store@entry=0x0, output_cred_handle=0x556b5eff0378, > actual_mechs=0x0, time_rec=0x0) at g_acquire_cred.c:190 > #11 0x00007fe592a2e096 in gss_acquire_cred (minor_status=, desired_name=, time_req=, desired_mechs=, cred_usage=, output_cred_handle=, > actual_mechs=0x0, time_rec=0x0) at g_acquire_cred.c:107 > #12 0x0000556b5efec956 in ?? () > #13 0x0000556b5efe8f4d in ?? () > #14 0x00007fe592a6fceb in __libc_start_main (main=0x556b5efe8520, argc=1, argv=0x7ffc89691a48, init=, fini=, rtld_fini=, stack_end=0x7ffc89691a38) at ../csu/libc-start.c:308 > #15 0x0000556b5efe921a in ?? () > (gdb) p h > $1 = {retrans = 5, retry = 2, options = 705, nscount = 1, nsaddr_list = {{sin_family = 2, sin_port = 13568, sin_addr = {s_addr = 16777343}, sin_zero = "\000\000\000\000\000\000\000"}, {sin_family = 0, sin_port = 0, sin_addr = { > s_addr = 0}, sin_zero = "\000\000\000\000\000\000\000"}, {sin_family = 0, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\000\000\000\000\000\000\000"}}, id = 0, dnsrch = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, > defdname = '\000' , pfcode = 0, ndots = 1, nsort = 0, ipv6_unavail = 0, unused = 0, sort_list = {{addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = { > s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, mask = 0}, {addr = {s_addr = 0}, > mask = 0}}, __glibc_unused_qhook = 0x0, __glibc_unused_rhook = 0x0, res_h_errno = 0, _vcsock = -1, _flags = 0, _u = {pad = "\000\000\000\000\000\000\000\000\377\377\377\377", '\000' , "a\200\257H", _ext = { > nscount = 0, nsmap = {0, 0, 0}, nssocks = {-1, 0, 0}, nscount6 = 0, nsinit = 0, nsaddrs = {0x0, 0x0, 0x0}, __glibc_reserved = {1219461217, 648608350}}}} > (gdb) p h.dnsrch > $2 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0} Trying to strdup the NULL pointer is not a good idea. So k5_primary_domain should return NULL if the domain is NULL. Something like: -#define PRIMARY_DOMAIN(h) strdup(h.dnsrch[0]) +#define PRIMARY_DOMAIN(h) ((h).dnsrch[0] ? strdup((h).dnsrch[0]) : NULL) And perhaps for the old res_init case too. thanks, -- js suse labs