Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.411 (Entity 5.404)
X-RT-Original-Encoding: iso-8859-1
Content-Length: 2989

From ghudson@MIT.EDU  Mon Sep 28 11:03:17 1998
Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id LAA05962 for <bugs@RT-11.MIT.EDU>; Mon, 28 Sep 1998 11:03:17 -0400
Received: from SMALL-GODS.MIT.EDU by MIT.EDU with SMTP
	id AA02096; Mon, 28 Sep 98 11:03:16 EDT
Received: by small-gods.mit.edu (SMI-8.6/4.7) id LAA15444; Mon, 28 Sep 1998 11:03:15 -0400
Message-Id: <199809281503.LAA15444@small-gods.mit.edu>
Date: Mon, 28 Sep 1998 11:03:15 -0400
From: ghudson@MIT.EDU
Reply-To: ghudson@MIT.EDU
To: krb5-bugs@MIT.EDU
Subject: kcmd error reporting
X-Send-Pr-Version: 3.99

>Number:         639
>Category:       krb5-appl
>Synopsis:       kcmd reports a couple of errors to stdout
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    krb5-unassigned
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Mon Sep 28 11:04:00 EDT 1998
>Last-Modified:  Thu Oct 08 01:50:31 EDT 1998
>Originator:     Greg Hudson
>Organization:
MIT
>Release:        1.0pl1
>Environment:
	
System: SunOS small-gods.mit.edu 5.6 Generic_105181-05 sun4u sparc SUNW,Ultra-5_10
Architecture: sun4

>Description:
If krb5_sendauth() fails in src/appl/bsd/kcmd.c, the resulting error
message is displayed to stdout.  It should go to stderr.

I report this as a fairly serious problem because it can easily confuse
scripts using rsh.
>How-To-Repeat:
rsh to a krb4 machine, or something, and notice that the krb5_sendauth()
error goes to stdout.
>Fix:

Index: kcmd.c
===================================================================
RCS file: /afs/dev.mit.edu/source/repository/third/krb5/src/appl/bsd/kcmd.c,v
retrieving revision 1.3
diff -c -r1.3 kcmd.c
*** kcmd.c	1998/08/14 19:44:58	1.3
--- kcmd.c	1998/09/28 14:49:39
***************
*** 343,352 ****
  			   authopts, &cksumdat, ret_cred, 0,	&error, &rep_ret, NULL);
  	krb5_xfree(cksumdat.data);
      if (status) {
! 	printf("Couldn't authenticate to server: %s\n", error_message(status));
  	if (error) {
! 	    printf("Server returned error code %d (%s)\n", error->error,
! 		   error_message(ERROR_TABLE_BASE_krb5 + error->error));
  	    if (error->text.length) {
  		fprintf(stderr, "Error text sent from server: %s\n",
  			error->text.data);
--- 343,354 ----
  			   authopts, &cksumdat, ret_cred, 0,	&error, &rep_ret, NULL);
  	krb5_xfree(cksumdat.data);
      if (status) {
! 	fprintf(stderr, "Couldn't authenticate to server: %s\n",
! 		error_message(status));
  	if (error) {
! 	    fprintf(stderr, "Server returned error code %d (%s)\n",
! 		    error->error,
! 		    error_message(ERROR_TABLE_BASE_krb5 + error->error));
  	    if (error->text.length) {
  		fprintf(stderr, "Error text sent from server: %s\n",
  			error->text.data);
>Audit-Trail:

State-Changed-From-To: open-closed
State-Changed-By: tytso
State-Changed-When: Thu Oct  8 01:48:59 1998
State-Changed-Why: This was already fixed in our tree.

>Unformatted: