Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.411 (Entity 5.404)
X-RT-Original-Encoding: iso-8859-1
Content-Length: 2229

From donn@u.washington.edu  Mon Mar 20 16:14:27 2000
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2])
	by rt-11.mit.edu (8.9.3/8.9.3) with SMTP id QAA15768
	for <bugs@RT-11.MIT.EDU>; Mon, 20 Mar 2000 16:14:27 -0500 (EST)
Received: from melville.u.washington.edu by MIT.EDU with SMTP
	id AA18885; Mon, 20 Mar 00 16:14:23 EST
Received: (from donn@localhost)
	by melville.u.washington.edu (8.9.3+UW99.09/8.9.3+UW99.09) id NAA78598;
	Mon, 20 Mar 2000 13:14:25 -0800
Message-Id: <200003202114.NAA78598@melville.u.washington.edu>
Date: Mon, 20 Mar 2000 13:14:25 -0800
From: donn@u.washington.edu
Reply-To: donn@u.washington.edu
To: krb5-bugs@MIT.EDU
Cc:
Subject: login.c "else" bug
X-Send-Pr-Version: 3.99

>Number:         833
>Category:       krb5-appl
>Synopsis:       login.krb5 may omit job control setup
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    krb5-unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Mon Mar 20 16:15:01 EST 2000
>Last-Modified:
>Originator:     Donn Cave
>Organization:
University Computing Services
University of Washington
>Release:        krb5-1.1.1
>Environment:
AIX 4.3  (doesn't matter.)
No Kerberos 4 compatibility.
[app-defaults] krb5_get_tickets = 1

>Description:
Section of login.c in question tries to make execution of dofork()
conditional on get tickets options for Kerberos 4 and 5.

Conditional compilation without krb4 omits else clause but leaves
the "else" itself, so following code block is executed only if
the "if" tests false.

This block does the process group setup for job control.

>How-To-Repeat:
Compile without Kerberos 4, set krb5_get_tickets true, log in via
telnet + Kerberos 5 authentication, try to use job control feature like
resume background process.

>Fix:

Diff won't match your line numbers due to other patches, but it should
be fairly easy to find this one.

*** 1456,1463 ****
--- 1539,1548 ----
  #ifdef KRB5_GET_TICKETS
      if (login_krb5_get_tickets)
        dofork();
+ #ifdef KRB4_GET_TICKETS
      else
+ #endif
  #endif
  #ifdef KRB4_GET_TICKETS
        if (login_krb4_get_tickets)
            dofork();
***************
>Audit-Trail:
>Unformatted: