Received: from pch.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.9.3p2) with ESMTP id XAA03639; Wed, 1 Sep 2004 23:50:40 -0400 (EDT) Received: from pch.mit.edu (localhost [127.0.0.1]) by pch.mit.edu (8.12.8p2/8.12.8) with ESMTP id i823odWM025584 for ; Wed, 1 Sep 2004 23:50:39 -0400 (EDT) Received: from pacific-carrier-annex.mit.edu (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.7.21.83]) by pch.mit.edu (8.12.8p2/8.12.8) with ESMTP id i823ocWM025579 for ; Wed, 1 Sep 2004 23:50:38 -0400 (EDT) Received: from cz.mit.edu (HOTASS-6.MIT.EDU [18.101.1.48]) i823oavT007388 for ; Wed, 1 Sep 2004 23:50:36 -0400 (EDT) Received: by cz.mit.edu (Postfix, from userid 8042) id C8C97E004D; Wed, 1 Sep 2004 23:51:20 -0400 (EDT) To: krb5-bugs@mit.edu From: Sam Hartman Date: Wed, 01 Sep 2004 23:51:20 -0400 Message-Id: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: fake-addrinfo.h calls sprintf without including stdio.h X-Beenthere: krb5-bugs-incoming@mit.edu X-Mailman-Version: 2.1 Precedence: list Sender: krb5-bugs-incoming-bounces@mit.edu Errors-To: krb5-bugs-incoming-bounces@mit.edu X-RT-Original-Encoding: us-ascii Content-Length: 626 This break the build of 1.3.x on Solaris 7. ASST is believed to consider this problem critical. In addition: 1) We seem to have compiler and CPU tests in get-addrinfo.h. That's wrong; use a feature test macro even if the only way of setting the feature test macro you know is based on cpu and compiler. The separation serves as documentation and abstraction and is useful for porting. 2) || 1 is bad form in committed code. If it really is what you always want, then remove the other fork of the preprocessor macro. 3) IT seems that we got a thread related pull up to the 1.3.x branch based on this.