Received: from mailman.mit.edu (PCH.MIT.EDU [18.7.21.90]) by krbdev.mit.edu (8.9.3p2) with ESMTP id PAA22531; Fri, 5 Nov 2004 15:10:14 -0500 (EST) Received: from pch.mit.edu (pch.mit.edu [127.0.0.1]) by mailman.mit.edu (8.12.8p2/8.12.8) with ESMTP id iA5K9rYR024537 for ; Fri, 5 Nov 2004 15:09:53 -0500 Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.7.7.76]) by mailman.mit.edu (8.12.8p2/8.12.8) with ESMTP id iA539v23004116 for ; Thu, 4 Nov 2004 22:10:04 -0500 Received: from lists.samba.org (dp.samba.org [66.70.73.150]) iA51xdXK025716 for ; Thu, 4 Nov 2004 20:59:39 -0500 (EST) Received: by lists.samba.org (Postfix, from userid 549) id 38908162BC3; Fri, 5 Nov 2004 01:59:39 +0000 (GMT) Date: Thu, 4 Nov 2004 17:59:37 -0800 From: Jeremy Allison To: krb5-bugs@mit.edu Message-Id: <20041105015937.GC28820@legion.cup.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Scanned-BY: MIMEDefang 2.42 X-Mailman-Approved-At: Fri, 05 Nov 2004 15:05:30 -0500 Cc: jra@samba.org Subject: Bad prototypes. X-Beenthere: krb5-bugs-incoming@mit.edu X-Mailman-Version: 2.1 Precedence: list Reply-To: Jeremy Allison Sender: krb5-bugs-incoming-bounces@mit.edu Errors-To: krb5-bugs-incoming-bounces@mit.edu X-RT-Original-Encoding: us-ascii Content-Length: 2062 Hi, is there any chance of the following patch being accepted for the next release ? I compile Samba with maximum warnings and the use of void fn() instead of the standard C method of : void fn(void) always causes nasty warnings on every file :-(. Jeremy. ----------------------------------------------------------------------- --- /usr/kerberos-1.3.5/include/krb5.h.orig 2004-11-04 16:45:35.000000000 -0800 +++ /usr/kerberos-1.3.5/include/krb5.h 2004-11-04 16:47:39.000000000 -0800 @@ -2860,7 +2860,7 @@ #if !defined(_WIN32) /* for compatibility with older versions... */ -extern void initialize_krb5_error_table () /*@modifies internalState@*/; +extern void initialize_krb5_error_table (void) /*@modifies internalState@*/; #else #define initialize_krb5_error_table() #endif @@ -2911,7 +2911,7 @@ #if !defined(_WIN32) /* for compatibility with older versions... */ -extern void initialize_kdb5_error_table () /*@modifies internalState@*/; +extern void initialize_kdb5_error_table (void) /*@modifies internalState@*/; #else #define initialize_kdb5_error_table() #endif @@ -2990,7 +2990,7 @@ #if !defined(_WIN32) /* for compatibility with older versions... */ -extern void initialize_kv5m_error_table () /*@modifies internalState@*/; +extern void initialize_kv5m_error_table (void) /*@modifies internalState@*/; #else #define initialize_kv5m_error_table() #endif @@ -3021,7 +3021,7 @@ #if !defined(_WIN32) /* for compatibility with older versions... */ -extern void initialize_k524_error_table () /*@modifies internalState@*/; +extern void initialize_k524_error_table (void) /*@modifies internalState@*/; #else #define initialize_k524_error_table() #endif @@ -3056,7 +3056,7 @@ #if !defined(_WIN32) /* for compatibility with older versions... */ -extern void initialize_asn1_error_table () /*@modifies internalState@*/; +extern void initialize_asn1_error_table (void) /*@modifies internalState@*/; #else #define initialize_asn1_error_table() #endif -----------------------------------------------------------------------