Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.411 (Entity 5.404)
X-RT-Original-Encoding: iso-8859-1
Content-Length: 3130

From ratliff@austin.ibm.com  Mon Oct  1 17:19:29 2001
Received: from fort-point-station.mit.edu (FORT-POINT-STATION.MIT.EDU [18.72.0.53])
	by rt-11.mit.edu (8.9.3/8.9.3) with ESMTP id RAA00232
	for <bugs@RT-11.mit.edu>; Mon, 1 Oct 2001 17:19:29 -0400 (EDT)
Received: from mg01.austin.ibm.com (mg01.austin.ibm.com [192.35.232.18])
	by fort-point-station.mit.edu (8.9.2/8.9.2) with ESMTP id RAA29704
	for <krb5-bugs@mit.edu>; Mon, 1 Oct 2001 17:19:28 -0400 (EDT)
Received: from austin.ibm.com (netmail.austin.ibm.com [9.3.7.137])
	by mg01.austin.ibm.com (AIX4.3/8.9.3/8.9.3) with ESMTP id QAA27380
	for <krb5-bugs@mit.edu>; Mon, 1 Oct 2001 16:20:50 -0500
Received: from spiff.austin.ibm.com (spiff.austin.ibm.com [9.53.216.123])
	by austin.ibm.com (AIX4.3/8.9.3/8.9.3) with ESMTP id QAA29832
	for <krb5-bugs@mit.edu>; Mon, 1 Oct 2001 16:19:27 -0500
Received: by spiff.austin.ibm.com (Postfix, from userid 501)
	id C54AF82C06; Mon,  1 Oct 2001 16:19:24 -0500 (CDT)
Message-Id: <20011001211924.C54AF82C06@spiff.austin.ibm.com>
Date: Mon,  1 Oct 2001 16:19:24 -0500 (CDT)
From: ratliff@austin.ibm.com
Reply-To: ratliff@austin.ibm.com
To: krb5-bugs@mit.edu
Subject: ksu plain_dump_principal call error
X-Send-Pr-Version: 3.99

>Number:         998
>Category:       krb5-clients
>Synopsis:       Call to plain_dump_principal has incorrect parameters
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mitchb
>State:          closed
>Class:          sw-bug
>Submitter-Id:   unknown
>Arrival-Date:   Mon Oct  1 17:20:00 EDT 2001
>Last-Modified:  Sun Oct  7 04:08:33 EDT 2001
>Originator:     Emily Ratliff
>Organization:
IBM Linux Technology Center, Security
>Release:        krb5-1.2.2
>Environment:
	
System: Linux spiff.austin.ibm.com 2.2.17-21mdk #1 Thu Oct 5 13:16:08 CEST 2000 i686 unknown
Architecture: i686

>Description:
	src/clients/ksu/krb_auth_su.c contains a call to plain_dump_principal
	which is invoked when GET_TGT_VIA_PASSWD is not defined that only
	supplies the client and not the context parameter. The result
	is a core dump when this code is invoked. It is rarely invoked
	and thus a low priority but the fix is simple and clean.
>How-To-Repeat:
	Compile krb5-current with GET_TGT_VIA_PASSWD undefined and issue ksu.
>Fix:

diff -ur src.old/clients/ksu/krb_auth_su.c src/clients/ksu/krb_auth_su.c
--- src.old/clients/ksu/krb_auth_su.c	Thu Sep 13 15:38:48 2001
+++ src/clients/ksu/krb_auth_su.c	Mon Oct  1 16:02:34 2001
@@ -165,7 +165,7 @@
 	}
 	
 #else
-	plain_dump_principal (client);
+	plain_dump_principal (context, client);
 	fprintf(stderr,"does not have any appropriate tickets in the cache.\n");
 	return FALSE;
 	
>Audit-Trail:
State-Changed-From-To: open-closed 
State-Changed-By: mitchb 
State-Changed-When: Sun Oct 7 04:06:37 EDT 2001 
State-Changed-Why:  
I've committed this patch - thanks for catching this and contributing! 
 
 
Responsible-Changed-From-To: krb5-unassigned->mitchb 
Responsible-Changed-By: mitchb 
Responsible-Changed-When: Sun Oct 7 04:06:37 EDT 2001 
Responsible-Changed-Why:  
mitchb reviewed and verified the problem and patch 

>Unformatted: