Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.411 (Entity 5.404) X-RT-Original-Encoding: iso-8859-1 Content-Length: 2043 From fcusack@ratbert.iconnet.net Thu Oct 29 20:53:46 1998 Received: from MIT.EDU (PACIFIC-CARRIER-ANNEX.MIT.EDU [18.69.0.28]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id UAA17838 for ; Thu, 29 Oct 1998 20:53:46 -0500 Received: from ratbert.iconnet.net by MIT.EDU with SMTP id AA02371; Thu, 29 Oct 98 20:53:50 EST Received: (from fcusack@localhost) by ratbert.iconnet.net (8.9.1/8.9.1) id UAA24627; Thu, 29 Oct 1998 20:54:13 -0500 (EST) Message-Id: <199810300154.UAA24627@ratbert.iconnet.net> Date: Thu, 29 Oct 1998 20:54:13 -0500 (EST) From: fcusack@iconnet.net Reply-To: fcusack@iconnet.net To: krb5-bugs@MIT.EDU Subject: krb5_md5_sum_func uses hardcoded `16' as checksum length X-Send-Pr-Version: 3.99 >Number: 653 >Category: krb5-libs >Synopsis: krb5_md5_sum_func uses hardcoded `16' as checksum length >Confidential: no >Severity: non-critical >Priority: low >Responsible: krb5-unassigned >State: closed >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Thu Oct 29 20:54:01 EST 1998 >Last-Modified: Fri Jan 22 00:57:54 EST 1999 >Originator: Frank Cusack >Organization: Icon CMT Corp. >Release: krb5-current-19981012 >Environment: N/A System: SunOS ratbert 5.6 Generic_105181-09 sun4u sparc SUNW,Ultra-5_10 Architecture: sun4 >Description: See Fix >How-To-Repeat: N/A >Fix: diff -u -r1.1.1.1 md5glue.c --- md5glue.c 1998/10/14 00:47:05 1.1.1.1 +++ md5glue.c 1998/10/30 01:53:22 @@ -40,7 +40,8 @@ outcksum->checksum_type = CKSUMTYPE_RSA_MD5; outcksum->length = RSA_MD5_CKSUM_LENGTH; - memcpy((char *)outcksum->contents, (char *)&working.digest[0], 16); + memcpy((char *)outcksum->contents, (char *)&working.digest[0], + RSA_MD5_CKSUM_LENGTH); memset((char *)&working, 0, sizeof(working)); return 0; >Audit-Trail: State-Changed-From-To: open-closed State-Changed-By: tytso State-Changed-When: Fri Jan 22 00:57:45 1999 State-Changed-Why: no longer relevent with new crypto code >Unformatted: