Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.411 (Entity 5.404) X-RT-Original-Encoding: iso-8859-1 Content-Length: 4260 From jik@kamens.brookline.ma.us Tue Nov 23 16:58:39 1999 Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id QAA02328 for ; Tue, 23 Nov 1999 16:58:38 -0500 Received: from polaris.shore.net by MIT.EDU with SMTP id AA26036; Tue, 23 Nov 99 16:58:30 EST Received: from jik.shore.net [206.243.167.15] by polaris.shore.net with esmtp (Exim) for krb5-bugs@mit.edu id 11qNxI-0001VT-00; Tue, 23 Nov 1999 16:58:32 -0500 Received: from jik2.kamens.brookline.ma.us (IDENT:root@jik2.kamens.brookline.ma.us [192.168.0.3]) by jik.shore.net (8.9.0/8.9.0) with ESMTP id QAA22209; Tue, 23 Nov 1999 16:57:58 -0500 Received: (from jik@localhost) by jik2.kamens.brookline.ma.us (8.9.3/8.9.3) id QAA21256; Tue, 23 Nov 1999 16:58:50 -0500 Message-Id: <199911232158.QAA21256@jik2.kamens.brookline.ma.us> Date: Tue, 23 Nov 1999 16:58:50 -0500 From: Jonathan Kamens Reply-To: jik@kamens.brookline.ma.us To: krb5-bugs@MIT.EDU Cc: jik@kamens.brookline.ma.us Subject: telnet Makefile needs to specify -I$(srcdir) X-Send-Pr-Version: 3.99 >Number: 790 >Category: telnet >Synopsis: telnet Makefile needs to specify -I$(srcdir) >Confidential: yes >Severity: serious >Priority: medium >Responsible: hartmans >State: open >Class: sw-bug >Submitter-Id: unknown >Arrival-Date: Tue Nov 23 16:59:00 EST 1999 >Last-Modified: Tue Nov 30 21:00:01 EST 1999 >Originator: Jonathan Kamens >Organization: >Release: krb5-1.1 >Environment: System: Linux jik2 2.2.12-20 #14 Thu Nov 18 20:57:02 EST 1999 i686 unknown Architecture: i686 >Description: The Makefile.in in src/appl/telnet/telnet needs to specify -I$(srcdir) to the compiler, or telnet won't build when the entire krb5 tree is being built with an alternate build root (i.e., the object files are in a different tree from the source files). Patch below. >How-To-Repeat: >Fix: Index: ./src/appl/telnet/telnet/Makefile.in --- Makefile.in 1999/11/23 21:12:04 1.1 +++ Makefile.in 1999/11/23 21:34:53 1.2 @@ -26,7 +26,7 @@ AUTH_DEF=-DAUTHENTICATION -DENCRYPTION -DKRB5 -DFORWARD -UNO_LOGIN_F -DLOGIN_CAP_F -DLOGIN_PROGRAM=KRB5_PATH_LOGIN OTHERDEFS=-DLINEMODE -DKLUDGELINEMODE -DDIAGNOSTICS -DENV_HACK -DOLD_ENVIRON -LOCALINCLUDES=-I.. -I$(srcdir)/.. +LOCALINCLUDES=-I.. -I$(srcdir)/.. -I$(srcdir) CFLAGS = $(CCOPTS) $(AUTH_DEF) $(OTHERDEFS) $(DEFS) $(LOCALINCLUDES) ARPA_TELNET= $(srcdir)/../arpa/telnet.h >Audit-Trail: From: Ken Raeburn To: jik@kamens.brookline.ma.us Cc: krb5-bugs@MIT.EDU Subject: Re: telnet/790: telnet Makefile needs to specify -I$(srcdir) Date: 30 Nov 1999 17:51:40 -0500 Jonathan Kamens writes: > The Makefile.in in src/appl/telnet/telnet needs to specify > -I$(srcdir) to the compiler, or telnet won't build when the > entire krb5 tree is being built with an alternate build root > (i.e., the object files are in a different tree from the > source files). Patch below. What sort of environment are you working in? That's the *only* way I've been building it, and I haven't noticed any problems, though most of my tests are with gcc. Have you got a compiler that doesn't automatically look in the source directory when processing include directives? Ken From: Jonathan Kamens To: raeburn@MIT.EDU Cc: krb5-bugs@MIT.EDU Subject: Re: telnet/790: telnet Makefile needs to specify -I$(srcdir) Date: Tue, 30 Nov 1999 20:03:11 -0500 > From: Ken Raeburn > Date: 30 Nov 1999 17:51:40 -0500 > > What sort of environment are you working in? I don't know the details any longer, I originally wrote that patch and submitted it to the MIT krb5 team years ago at OpenVision, but it was never incorporated, so I resubmitted it after merging it into the current tree. I assure you that it *was* a problem on at least one of the platforms on which I was building. In any case, (a) it is standard operating procedure to include -I$(srcdir) in a configurized Makefile.in -- I've seen it in many different projects -- and (b) it certainly doesn't hurt anything to include it. jik >Unformatted: