Skip Menu |
 

To: rt-krb5@krbdev.mit.edu
Subject: bogus return value from krb5_auth_con_genaddrs()
Date: Tue, 27 Aug 2002 18:28:42 -0400
From: Garry Zacheiss <zacheiss@MIT.EDU>
This code exists in krb5_auth_con_genaddrs():

if ((flags & KRB5_AUTH_CONTEXT_GENERATE_REMOTE_FULL_ADDR) ||
(flags & KRB5_AUTH_CONTEXT_GENERATE_REMOTE_ADDR)) {
if ((retval = getpeername(fd, (struct sockaddr *) &rsaddr, &ssize)))
return retval;

This is unfortunate because getpeername returns -1 and sets
errno on error; passing -1 to com_err gets you a useless "____ 255" as
your error message.

Returning errno would be an improvement over the current
situation, but returning something more meaningful would be even better.

Garry
From: hartmans@mit.edu
Subject: CVS Commit
Return errno not retval from getpeername failure


To generate a diff of this commit:



cvs diff -r5.323 -r5.324 krb5/src/lib/krb5/os/ChangeLog
cvs diff -r5.16 -r5.17 krb5/src/lib/krb5/os/genaddrs.c