Skip Menu |
 

History Show all quoted text — Show full headers
# Fri Oct 11 02:05:14 2002 tlyu (Taylor Yu) - Ticket created
From: tlyu@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 743B
This commit fixes one incompatibility introduced when
krb5_read_password was reimplemented in terms of krb5_prompter_posix.
There is a remaining incompatibility, which is krb5_prompter_posix's
appending of the string ": " following a prompt. Callers of
krb5_read_password and of des_read_password don't expect this
behavior, which results in a double colon prompt, which breaks the
libkadm5 test suite.

* read_pwd.c (krb5_read_password): Restore name of size_return.
Set *size_return after successful call to krb5_prompter_posix,
since some callers were actually checking, e.g. kadm5.


To generate a diff of this commit:



cvs diff -r5.328 -r5.329 krb5/src/lib/krb5/os/ChangeLog
cvs diff -r5.45 -r5.46 krb5/src/lib/krb5/os/read_pwd.c
# Fri Oct 11 02:05:15 2002 tlyu (Taylor Yu) - Status changed from 'new' to 'resolved'
# Fri Oct 11 02:05:16 2002 tlyu (Taylor Yu) - Requestor tlyu (Taylor Yu) added
# Fri Oct 11 02:06:26 2002 tlyu (Taylor Yu) - Status changed from 'resolved' to 'open'
# Fri Oct 18 21:22:35 2002 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 552B
This commit fixes the test suite aspects. Callers of the various
read_password functions still need to be updated.

* api.2/init-v2.exp (test106): Make regexp more forgiving of
variant password prompts.

* api.0/init.exp (test7, test22, test225): Make regexp more
forgiving of variant password prompts.


To generate a diff of this commit:



cvs diff -r1.52 -r1.53 krb5/src/lib/kadm5/unit-test/ChangeLog
cvs diff -r1.26 -r1.27 krb5/src/lib/kadm5/unit-test/api.0/init.exp
cvs diff -r1.15 -r1.16
krb5/src/lib/kadm5/unit-test/api.2/init-v2.exp
# Sat Nov 02 13:27:15 2002 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 432B
This fixes some test suite password prompt checks that were missed
earlier.

* kpasswd.0/changing.exp:
* lib/helpers.exp: Make checks for password prompts more lenient.


To generate a diff of this commit:



cvs diff -r1.9 -r1.10 krb5/src/kadmin/passwd/unit-test/ChangeLog
cvs diff -r1.14 -r1.15
krb5/src/kadmin/passwd/unit-test/kpasswd.0/changing.exp
cvs diff -r1.2 -r1.3
krb5/src/kadmin/passwd/unit-test/lib/helpers.exp
# Tue Nov 05 19:43:01 2002 tlyu (Taylor Yu) - Target_Version 1.3 added
# Tue Nov 05 19:43:02 2002 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 1.3KiB
This commit fixes up the in-tree callers of krb5_read_password() and
des_read_password(). We should perhaps tighten up the test suite now.


To generate a diff of this commit:



cvs diff -r5.362 -r5.363 krb5/src/appl/bsd/ChangeLog
cvs diff -r5.96 -r5.97 krb5/src/appl/bsd/login.c
cvs diff -r5.68 -r5.69 krb5/src/clients/kinit/ChangeLog
cvs diff -r5.71 -r5.72 krb5/src/clients/kinit/kinit.c
cvs diff -r1.324 -r1.325 krb5/src/include/ChangeLog
cvs diff -r1.129 -r1.130 krb5/src/include/k5-int.h
cvs diff -r5.201 -r5.202 krb5/src/include/krb5/ChangeLog
cvs diff -r5.75 -r5.76 krb5/src/include/krb5/kdb.h
cvs diff -r1.76 -r1.77 krb5/src/kadmin/cli/ChangeLog
cvs diff -r1.56 -r1.57 krb5/src/kadmin/cli/kadmin.c
cvs diff -r1.76 -r1.77 krb5/src/kadmin/dbutil/ChangeLog
cvs diff -r1.10 -r1.11 krb5/src/kadmin/dbutil/dumpv4.c
cvs diff -r1.21 -r1.22 krb5/src/kadmin/dbutil/loadv4.c
cvs diff -r1.36 -r1.37 krb5/src/kadmin/ktutil/ChangeLog
cvs diff -r1.16 -r1.17 krb5/src/kadmin/ktutil/ktutil_funcs.c
cvs diff -r1.26 -r1.27 krb5/src/kadmin/passwd/ChangeLog
cvs diff -r1.11 -r1.12 krb5/src/kadmin/passwd/kpasswd_strings.et
cvs diff -r1.31 -r1.32 krb5/src/kadmin/v5passwdd/ChangeLog
cvs diff -r1.10 -r1.11 krb5/src/kadmin/v5passwdd/kpasswd.c
cvs diff -r1.83 -r1.84 krb5/src/lib/kadm5/ChangeLog
cvs diff -r1.9 -r1.10 krb5/src/lib/kadm5/chpass_util_strings.et
# Wed Nov 06 13:27:21 2002 tlyu (Taylor Yu) - Status changed from 'open' to 'resolved'
# Wed Mar 12 20:53:55 2003 tlyu (Taylor Yu) - Version_Fixed 1.3 added