| To: | krb5-bugs@MIT.EDU |
| Subject: | test suites should kill servers on exiting |
| From: | Ken Raeburn <raeburn@MIT.EDU> |
| Date: | Fri, 01 Nov 2002 23:36:13 -0500 |
Some of our test suites rely on "make check" running the commands for
three targets in sequence, (1) starting up daemons, (2) running
dejagnu tests, (3) killing daemons. But if (2) fails, (3) doesn't
happen. The daemons will be killed as part of the startup in the next
run, but only if that run is as root or the same uid as the previous
run; if they're run by two different non-root users, the second will
not be able to bind to the desired port numbers and the tests will
fail.
Suggested fix:
A shell script or expect script to start the daemons, run the tests,
record the exit status, kill the daemons, and return the correct exit
status.
Rewrite the makefile rules to invoke the dejagnu test suite via this
script.
three targets in sequence, (1) starting up daemons, (2) running
dejagnu tests, (3) killing daemons. But if (2) fails, (3) doesn't
happen. The daemons will be killed as part of the startup in the next
run, but only if that run is as root or the same uid as the previous
run; if they're run by two different non-root users, the second will
not be able to bind to the desired port numbers and the tests will
fail.
Suggested fix:
A shell script or expect script to start the daemons, run the tests,
record the exit status, kill the daemons, and return the correct exit
status.
Rewrite the makefile rules to invoke the dejagnu test suite via this
script.