Skip Menu |
 

History Show all quoted text — Show full headers
# Tue Feb 04 11:46:57 2003 Dave Love <d.love@dl.ac.uk> - Ticket created
To: krb5-bugs@mit.edu
Subject: fix for requiring gawk
From: Dave Love <d.love@dl.ac.uk>
Date: 04 Feb 2003 16:37:16 +0000
Download (untitled) / with headers
text/plain 1KiB
I tried building 1.2.7 on a Solaris 8 box without gawk installed, and
it failed. Here's a fix.

2003-02-04 Dave Love <d.love@dl.ac.uk>

* Makefile.in (AWK): Use @AWK@.

* configure.in: Use AC_PROG_AWK.

===================================================================
RCS file: Makefile.in,v
retrieving revision 1.1
diff -u -r1.1 Makefile.in
--- Makefile.in 2003/02/04 15:55:23 1.1
+++ Makefile.in 2003/02/04 16:36:28
@@ -341,9 +341,9 @@

#
# Part of building the PC release has to be done on Unix. This includes
-# anything the requires awk.
+# anything that requires awk.
#
-AWK = gawk
+AWK = @AWK@
AH = util/et/et_h.awk
AC = util/et/et_c.awk
INC = include/
===================================================================
RCS file: configure.in,v
retrieving revision 1.1
diff -u -r1.1 configure.in
--- configure.in 2003/02/04 15:50:17 1.1
+++ configure.in 2003/02/04 15:50:24
@@ -56,6 +56,7 @@
AC_PROG_ARCHIVE
AC_PROG_ARCHIVE_ADD
AC_PROG_RANLIB
+AC_PROG_AWK
AC_CHECK_FUNCS(memmove)
KRB5_BUILD_LIBOBJS
KRB5_BUILD_LIBRARY
# Tue Feb 04 22:15:33 2003 hartmans (Sam Hartman) - Correspondence added
To: rt@krbdev.mit.edu
Cc: krb5-prs@mit.edu
Subject: Re: [krbdev.mit.edu #1342] fix for requiring gawk
From: Sam Hartman <hartmans@mit.edu>
Date: Tue, 04 Feb 2003 22:15:29 -0500
RT-Send-Cc:
Download (untitled) / with headers
text/plain 170B
I think the problem is that we want people to run that target without
ever actually configuring Kerberos. So depending on configure does
not seem like a good solution.
# Mon Feb 24 14:08:33 2003 tlyu (Taylor Yu) - Status changed from 'new' to 'open'
# Mon Feb 24 14:08:33 2003 tlyu (Taylor Yu) - Given to tlyu (Taylor Yu)
# Mon Feb 24 14:08:33 2003 tlyu (Taylor Yu) - Correspondence added
Download (untitled) / with headers
text/plain 518B
[hartmans - Tue Feb 4 22:15:33 2003]:

Show quoted text
> I think the problem is that we want people to run that target without
> ever actually configuring Kerberos. So depending on configure does
> not seem like a good solution.


I think the thing to do would be to explicitly override the setting of
the AWK variable on the make command line if you need to actually use
the top-level targets that need it, e.g. kerbsrc.zip. I believe that
these targets really were written with the assumption that configure had
not yet been run.
# Wed Feb 26 18:47:21 2003 tlyu (Taylor Yu) - Correspondence added
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #1342] fix for requiring gawk
From: Tom Yu <tlyu@mit.edu>
Date: Wed, 26 Feb 2003 18:47:19 -0500
RT-Send-Cc:
Download (untitled) / with headers
text/plain 1.1KiB
Followups to bug-related email should not go directly to krb5-prs lest
they get lost... please use rt@krbdev.mit.edu or
rt-comment@krbdev.mit.edu as per the mail-followup-to and reply-to
headers.

Show quoted text
-------------------- Start of forwarded message --------------------
References: <rt-1342-4620.0.872262382826534@krbdev.mit.edu>
From: Dave Love <d.love@dl.ac.uk>
Date: 26 Feb 2003 23:19:24 +0000
Message-ID: <rzq7kbmaav7.fsf@albion.dl.ac.uk>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
Subject: Re: [krbdev.mit.edu #1342] fix for requiring gawk
Lines: 12

"Tom Yu via RT" <rt-comment@krbdev.mit.edu> writes:

> I think the thing to do would be to explicitly override the setting of
> the AWK variable on the make command line if you need to actually use
> the top-level targets that need it, e.g. kerbsrc.zip.

Indeed; I don't see why the normal case should lose. Failure to build
on anything without gawk installed as such is rather unfortunate.
_______________________________________________
krb5-bugs mailing list
krb5-bugs@mit.edu
http://mailman.mit.edu/mailman/listinfo/krb5-bugs

-------------------- End of forwarded message --------------------
# Wed Mar 12 18:41:03 2003 tlyu (Taylor Yu) - Correspondence added
To: rt@krbdev.mit.edu
Subject: Re: [krbdev.mit.edu #1342] fix for requiring gawk
From: Tom Yu <tlyu@mit.edu>
Date: Wed, 12 Mar 2003 18:41:01 -0500
RT-Send-Cc:
Download (untitled) / with headers
text/plain 588B
Show quoted text
>>>>> "DL" == Dave Love <d.love@dl.ac.uk> writes:

Show quoted text
DL> "Tom Yu via RT" <rt-comment@krbdev.mit.edu> writes:

Show quoted text
>> I think the thing to do would be to explicitly override the setting of
>> the AWK variable on the make command line if you need to actually use
>> the top-level targets that need it, e.g. kerbsrc.zip.

Show quoted text
DL> Indeed; I don't see why the normal case should lose. Failure to build
DL> on anything without gawk installed as such is rather unfortunate.

Just to be clear: you _were_ attempting to build kerbsrc.zip, not
actually attempting to build the Unix binaries, right?

---Tom
# Wed Mar 12 20:04:38 2003 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 296B
* Makefile.in (AWK): Default to awk, not gawk. User can override
on make's command line if necessary. Still, only really useful
for building kerbsrc.zip, etc.


To generate a diff of this commit:



cvs diff -r5.402 -r5.403 krb5/src/ChangeLog
cvs diff -r1.136 -r1.137 krb5/src/Makefile.in
# Fri Mar 28 17:59:02 2003 tlyu (Taylor Yu) - Status changed from 'open' to 'resolved'
# Fri Mar 28 17:59:08 2003 tlyu (Taylor Yu) - Component krb5-build added
# Fri Mar 28 17:59:09 2003 tlyu (Taylor Yu) - Version_Fixed 1.3 added