Ticket History #1613: kadmin truncates long date strings

Hi,

Minor bug fix for kadmin in 1.2.8 in diff -c format.

/* Our timezone GMT+1000 manages to squeeze the year %Y
out of the 30 char limit in array 'out' in kadmin.c

eg when dates displayed in kadmin get
"Fri Jan 11 17:47:46 GMT+1000 "

and not

"Fri Jan 11 17:47 GMT+1000 2015"

You'll only notice this if your kadmin is displaying
times in a local timezone and not GMT or EST */



*** kadmin.c.dist Fri Oct 12 11:52:33 2001
--- kadmin.c Tue Jun 17 11:59:18 2003
***************
*** 122,132 ****
krb5_timestamp when;
{
struct tm *tm;
! static char out[30];

time_t lcltim = when;
tm = localtime(&lcltim);
! strftime(out, 30, "%a %b %d %H:%M:%S %Z %Y", tm);
return out;
}

--- 122,132 ----
krb5_timestamp when;
{
struct tm *tm;
! static char out[36];

time_t lcltim = when;
tm = localtime(&lcltim);
! strftime(out, 36, "%a %b %d %H:%M:%S %Z %Y", tm);
return out;
}


--
David Shrimpton Systems Programmer
Software Infrastructure, Information Technology Services
University of Qld 4072 shrimpto@its.uq.edu.au
Brisbane Australia Phone 61 7 3365 7408

Added a little more buffer space than the supplied patch, and used sizeof.

* kadmin.c (strdate): Increase size of buffer to 40. Use sizeof for
length passed to strftime.


To generate a diff of this commit:



cvs diff -r1.81 -r1.82 krb5/src/kadmin/cli/ChangeLog
cvs diff -r1.58 -r1.59 krb5/src/kadmin/cli/kadmin.c