Ticket History #1631: includes targets cause spurious rebuilds with Irix native make

# Fri Jun 27 15:10:28 2003 tlyu (Taylor Yu) - Ticket created

To:	rt-krb5@krbdev.mit.edu
Subject:	includes targets cause spurious rebuilds with Irix native make
From:	Tom Yu <tlyu@mit.edu>
Date:	Fri, 27 Jun 2003 15:10:26 -0400

Download (untitled)
message/rfc822 1.1KiB

Return-Path: <herb@sgi.com>
Sender: herb@chomps.engr.sgi.com
Message-ID: <3EFA28E4.E3044199@sgi.com>
Date: Wed, 25 Jun 2003 15:57:40 -0700
From: Herb Lewis <herb@sgi.com>
Organization: Silicon Graphics Inc.
To: Tom Yu <tlyu@mit.edu>
Subject: Re: krb5-1.3-beta4 is available
References: <ldvel1tnvcj.fsf@cathode-dark-space.mit.edu>
Lines: 14
MIME-Version: 1.0

One other issue we have come up with is the Makefile targets for
includes causes manyfiles to be rebuilt every time when no changes
have happened because the includes target builds every time (no file
to test times against) and causes some header files to be rebuilt
thus causing files dependent on them to be rebuilt.
--
======================================================================
Herb Lewis Silicon Graphics
Networking Engineer 1600 Amphitheatre Pkwy MS-510
Strategic Software Organization Mountain View, CA 94043-1351
herb@sgi.com Tel: 650-933-2177
http://www.sgi.com Fax: 650-932-2177
PGP Key: 0x8408D65D
======================================================================

# Fri Jun 27 15:13:26 2003 tlyu (Taylor Yu) - Comments added

To:	rt-comment@krbdev.mit.edu
Subject:	[krbdev.mit.edu #1631]
From:	Tom Yu <tlyu@mit.edu>
Date:	Fri, 27 Jun 2003 15:13:24 -0400
RT-Send-Cc:

Download (untitled)
message/rfc822 3.2KiB

Return-Path: <herb@sgi.com>
Sender: herb@chomps.engr.sgi.com
Message-ID: <3EFC717B.72A5B746@sgi.com>
Date: Fri, 27 Jun 2003 09:31:55 -0700
From: Herb Lewis <herb@sgi.com>
Organization: Silicon Graphics Inc.
To: Tom Yu <tlyu@mit.edu>
Subject: Re: krb5-1.3-beta4 is available
References: <ldvel1tnvcj.fsf@cathode-dark-space.mit.edu>
<3EFA2803.EB1D2EC2@sgi.com> <ldv4r2cmuii.fsf@cathode-dark-space.mit.edu>
Lines: 72
MIME-Version: 1.0

Go ahead and forward them. I wasn't sure about the procedure for
submitting patches. On the make problem, I ran configure and
then make in the src directory. Immediately after that with no
changes to any files I run make again and many things recompile.
Here is a snippet of the output of make -d showing why things
were rebuilt.

making all in util/ss...
Re-making all-prerecurse since it doesn't exist
Re-making all-recurse since it doesn't exist
Re-making all-postrecurse since it doesn't exist
if [ -d ../../include/ss ] ; then :; else mkdir -p
../../include/ss; fi
for i in ss.h ; do \
if cmp ./$i ../../include/ss/$i >/dev/null 2>&1; then :;
\
else \
(set -x; rm -f ../../include/ss/$i; \
cp ./$i ../../include/ss/$i) ; \
fi ; \
done
for i in ss_err.h ; do \
if cmp $i ../../include/ss/$i >/dev/null 2>&1; then :; \
else \
(set -x; rm -f ../../include/ss/$i; \
cp $i ../../include/ss/$i) ; \
fi ; \
done
Re-making includes since it doesn't exist
Re-making ../../include/ss/ss_err.h since it is out-of-date w.r.t:
includes
Re-making invocation.o since it is out-of-date w.r.t:
../../include/ss/ss_err.h

Tom Yu wrote:

Show quoted text

>

> >>>>> "herb" == Herb Lewis <herb@sgi.com> writes:

>

> herb> There is a minor problem we have discovered in the file
> herb> krb5-1.3-beta4/src/lib/krb5/krb/gic_keytab.c

>
> [...]
>
> Hi Herb,
>
> I'm going to forward this (and your other note) to our (publicly
> readable) bug-tracking system tomorrow, unless you object. We're very
> likely to address the gic_keytab issue for the final 1.3 release. I'm
> less sure about the spurious rebuilds being addressed in time, though.
> As far as I know, there should be no reason for the include files'
> timestamps to change on a rebuild, as the Makefiles take precautions
> to avoid updating files that haven't changed. If you could provide
> specific examples of files being rebuilt when they shouldn't be, , it
> would help a lot.
>
> You may send directly to our bug-tracking system by emailing
> krb5-bugs@mit.edu, but please retain the subject line from the
> autoresponder when following up to mail sent here, to avoid spreading
> messages between different tickets.
>
> ---Tom

--
======================================================================
Herb Lewis Silicon Graphics
Networking Engineer 1600 Amphitheatre Pkwy MS-510
Strategic Software Organization Mountain View, CA 94043-1351
herb@sgi.com Tel: 650-933-2177
http://www.sgi.com Fax: 650-932-2177
PGP Key: 0x8408D65D
======================================================================

# Fri Jun 27 15:17:21 2003 tlyu (Taylor Yu) - Requestor <herb@sgi.com> added

# Fri Jun 27 15:17:21 2003 tlyu (Taylor Yu) - Status changed from 'new' to 'open'

# Fri Jun 27 15:17:21 2003 tlyu (Taylor Yu) - Given to tlyu (Taylor Yu)

# Fri Jun 27 15:17:22 2003 tlyu (Taylor Yu) - Component krb5-build added

# Fri Jun 27 15:17:22 2003 tlyu (Taylor Yu) - Version_reported 1.3 added

# Fri Jun 27 15:42:41 2003 tlyu (Taylor Yu) - Correspondence added

To:	rt@krbdev.mit.edu
Subject:	Re: [krbdev.mit.edu #1631]
From:	Tom Yu <tlyu@mit.edu>
Date:	Fri, 27 Jun 2003 15:42:40 -0400
RT-Send-Cc:

Download (untitled) / with headers
text/plain 289B

Ok, I've reproduced the spurious rebuilds on Irix and am scratching my
head about them. For now, using GNU make should be a workaround. I'm
suspicious of the Irix native make program treating ss_err.h as if it
depended on includes, when it really should be the other way around.

---Tom

# Fri Jun 27 16:36:28 2003 raeburn (Ken Raeburn) - Correspondence added

From:	raeburn@mit.edu
Subject:	CVS Commit

Download (untitled) / with headers
text/plain 683B

This change fixes the problem in the ss directory. It probably won't
get into our 1.3 release, but perhaps in a patch release afterwards.

I'll look and see where else things are getting needlessly rebuilt....

* Makefile.in (HDRS): Remove mit-sipb-copyright.h.
(includes): Depend on copied version of the headers, not local versions. Don't
do any copying; instead, move the copying commands to new targets for each
header.
($(HDRDIR)/timestamp): New target; create the directory here if needed.
(clean-unix): Remove the timestamp file.

To generate a diff of this commit:

cvs diff -r1.68 -r1.69 krb5/src/util/ss/ChangeLog
cvs diff -r1.48 -r1.49 krb5/src/util/ss/Makefile.in

# Fri Jun 27 16:58:13 2003 <herb@sgi.com> - Comments added

Date:	Fri, 27 Jun 2003 13:58:09 -0700
From:	Herb Lewis <herb@sgi.com>
To:	rt-comment@krbdev.mit.edu
Subject:	Re: [krbdev.mit.edu #1631]
RT-Send-Cc:

Download (untitled) / with headers
text/plain 917B

Tom Yu via RT wrote:

Show quoted text

>
> Ok, I've reproduced the spurious rebuilds on Irix and am scratching my
> head about them. For now, using GNU make should be a workaround. I'm
> suspicious of the Irix native make program treating ss_err.h as if it
> depended on includes, when it really should be the other way around.
>
> ---Tom

I've sent off an email to our compiler people as well. Thanks for the
tip about gmake working.

--
======================================================================
Herb Lewis Silicon Graphics
Networking Engineer 1600 Amphitheatre Pkwy MS-510
Strategic Software Organization Mountain View, CA 94043-1351
herb@sgi.com Tel: 650-933-2177
http://www.sgi.com Fax: 650-932-2177
PGP Key: 0x8408D65D
======================================================================

# Mon Oct 20 17:32:59 2008 tlyu (Taylor Yu) - Status changed from 'open' to 'resolved'

# Mon Oct 20 17:32:59 2008 tlyu (Taylor Yu) - Tags unsupported added

# Mon Jan 04 23:38:56 2010 tlyu (Taylor Yu) - Version_Fixed 1.8 added

# Tue Jan 05 18:49:13 2010 tlyu (Taylor Yu) - CustomField 1.8 deleted