Ticket History #193: krb5-beta7: appl/bsd/login.c doesn't preserve TERM env var

From jgm@portolacomm.com Thu Nov 14 19:56:25 1996
Received: from MIT.EDU (SOUTH-STATION-ANNEX.MIT.EDU [18.72.1.2]) by rt-11.MIT.EDU (8.7.5/8.7.3) with SMTP id TAA12398 for <bugs@RT-11.MIT.EDU>; Thu, 14 Nov 1996 19:56:15 -0500
Received: from [205.178.2.165] by MIT.EDU with SMTP
id AA07416; Thu, 14 Nov 96 19:56:13 EST
Received: from kerberos-2.portolacomm.com (kerberos-2.PortolaComm.Com [205.178.2.182]) by porta-sparc.portolacomm.com (1.0.b/8.8.2) with SMTP id QAA19871 for <krb5-bugs@athena.mit.edu>; Thu, 14 Nov 1996 16:53:42 -0800 (PST)
Message-Id: <Pine.LNX.3.95L.961114165449.452E-100000@kerberos-2.portolacomm.com>
Date: Thu, 14 Nov 1996 16:56:18 -0800 (PST)
From: John Gardiner Myers <jgm@cmu.edu>
Sender: jgm@kerberos-2.portolacomm.com
To: krb5-bugs@MIT.EDU
Subject: krb5-beta7: appl/bsd/login.c doesn't preserve TERM env var


Responsible-Changed-From-To: gnats-admin->krb5-unassigned
Responsible-Changed-By: tlyu
Responsible-Changed-When: Thu Nov 14 20:54:57 1996
Responsible-Changed-Why:
refiled

State-Changed-From-To: open-closed
State-Changed-By: hartmans
State-Changed-When: Thu Nov 14 22:02:38 1996
State-Changed-Why:
This was fixed long before the PR was filed; ChangeLog follows
Mon Sep 30 16:22:48 1996 Sam Hartman <hartmans@tertius.mit.edu>

* login.c (stypeof): If TERM environment variable set, use it.


I believe my fix is similar to yours.


login.krb5 doesn't preserve the value of the TERM environment variable.
Fix follows:

Index: login.c
===================================================================
RCS file: /usr/system/portola/cvsroot/security/krb5/src/appl/bsd/login.c,v
retrieving revision 1.1.1.1
diff -c -r1.1.1.1 login.c
*** login.c 1996/11/02 20:53:38 1.1.1.1
--- login.c 1996/11/15 00:51:54
***************
*** 1312,1317 ****
--- 1312,1321 ----
#endif
(void)fcntl(0, F_SETFL, ioctlval);

+ if ((p = getenv("TERM")) && strlen(p) < sizeof(term)) {
+ strcpy(term, p);
+ }
+
/*
* If talking to an rlogin process, propagate the terminal type
and
* baud rate across the network.