Skip Menu |
 

History Show all quoted text — Show full headers
# Thu Feb 12 13:17:32 2004 Wyllys Ingersoll <wyllys.ingersoll@sun.com> - Ticket created
Subject: kdc_util.c bug - validate_tgs_request clears all kdc_options
From: Wyllys Ingersoll <wyllys.ingersoll@sun.com>
To: krb5-bugs@mit.edu
Date: Thu, 12 Feb 2004 13:13:45 -0500
Download (untitled) / with headers
text/plain 465B

The new code in kdc_util.c

request->kdc_options &= ~(TGS_OPTIONS_HANDLED);

Actually causes clears the kdc_options field of all
handled options, which (in most cases) zeros the field.
This is probably not intended...

To properly disable unrecognized flags, I think you need
to do something like this:

badflags = (request->kdc_options & ~(TGS_OPTIONS_HANDLED));
request->kdc_options &= ~badflags;

-Wyllys

--
Wyllys Ingersoll <wyllys.ingersoll@sun.com>
# Thu Feb 12 13:30:39 2004 "Jeffrey Altman [Kermit Project]" <jaltman@columbia.edu> - Comments added
Date: Thu, 12 Feb 2004 13:31:00 -0500
From: Jeffrey Altman <jaltman@columbia.edu>
To: rt-comment@krbdev.mit.edu
Cc: krb5-prs@MIT.EDU
Subject: Re: [krbdev.mit.edu #2234] kdc_util.c bug - validate_tgs_request clears all kdc_options
RT-Send-Cc:
Download (untitled) / with headers
text/plain 542B
Download (untitled) / with headers
text/html 1015B
Wyllys Ingersoll via RT wrote:
Show quoted text
The new code in kdc_util.c

    request->kdc_options &= ~(TGS_OPTIONS_HANDLED);

Actually causes clears the kdc_options field of all
handled options, which (in most cases) zeros the field.
This is probably not intended...  

To properly disable unrecognized flags, I think you need
to do something like this:

badflags = (request->kdc_options & ~(TGS_OPTIONS_HANDLED));
request->kdc_options &= ~badflags;

-Wyllys
Shouldn't this simply be?

   request->kdc_options &= TGS_OPTIONS_HANDLED;


# Thu Feb 12 14:08:19 2004 Wyllys Ingersoll <wyllys.ingersoll@sun.com> - Comments added
Subject: Re: [krbdev.mit.edu #2234] kdc_util.c bug - validate_tgs_request clears all kdc_options
From: Wyllys Ingersoll <wyllys.ingersoll@sun.com>
To: rt-comment@krbdev.mit.edu
Cc: krb5-prs@mit.edu
Date: Thu, 12 Feb 2004 14:04:04 -0500
RT-Send-Cc:
Download (untitled) / with headers
text/plain 859B
On Thu, 2004-02-12 at 13:30, ""Jeffrey Altman [Kermit Project]" via RT"
wrote:
Show quoted text
> Wyllys Ingersoll via RT wrote:
>
> >The new code in kdc_util.c
> >
> > request->kdc_options &= ~(TGS_OPTIONS_HANDLED);
> >
> >Actually causes clears the kdc_options field of all
> >handled options, which (in most cases) zeros the field.
> >This is probably not intended...
> >
> >To properly disable unrecognized flags, I think you need
> >to do something like this:
> >
> >badflags = (request->kdc_options & ~(TGS_OPTIONS_HANDLED));
> >request->kdc_options &= ~badflags;
> >
> >-Wyllys
> >
> >
> Shouldn't this simply be?
>
> request->kdc_options &= TGS_OPTIONS_HANDLED;

er, yup. That'll work too, I was thinking in reverse :)

Though, the original suggestion might be OK if you wanted
to log a message to indicate what unsupported flags were received.

-Wyllys
# Thu Feb 12 23:20:59 2004 hartmans (Sam Hartman) - Status changed from 'new' to 'resolved'
# Thu Feb 12 23:20:59 2004 hartmans (Sam Hartman) - Tags pullup added
# Thu Feb 12 23:21:00 2004 hartmans (Sam Hartman) - Target_Version 1.3.2 added
# Thu Feb 12 23:21:00 2004 hartmans (Sam Hartman) - Given to hartmans (Sam Hartman)
# Thu Feb 12 23:21:00 2004 hartmans (Sam Hartman) - Correspondence added
From: hartmans@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 156B
Fix logic error.


To generate a diff of this commit:



cvs diff -r5.269 -r5.270 krb5/src/kdc/ChangeLog
cvs diff -r5.110 -r5.111 krb5/src/kdc/kdc_util.c
# Fri Feb 13 17:48:35 2004 tlyu (Taylor Yu) - Version_Fixed 1.3.2 added
# Fri Feb 13 17:48:36 2004 tlyu (Taylor Yu) - Correspondence added
From: tlyu@mit.edu
Subject: CVS Commit
Download (untitled) / with headers
text/plain 175B
pullup from trunk


To generate a diff of this commit:



cvs diff -r5.251.2.15 -r5.251.2.16 krb5/src/kdc/ChangeLog
cvs diff -r5.106.2.4 -r5.106.2.5 krb5/src/kdc/kdc_util.c
# Tue Feb 17 16:39:44 2004 tlyu (Taylor Yu) - Ticket 2234 RefersTo ticket 2189.
# Wed Dec 16 18:02:42 2015 tlyu (Taylor Yu) - CustomField pullup deleted